* [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX
@ 2021-06-24 18:24 Pratyush Yadav
2021-06-28 10:38 ` Péter Ujfalusi
0 siblings, 1 reply; 4+ messages in thread
From: Pratyush Yadav @ 2021-06-24 18:24 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: Pratyush Yadav, Vinod Koul, dmaengine, linux-kernel
The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can
have up to 32 threads per instance. J721E has two instances of the
subsystem, so there are 64 threads total. Add them to the endpoint map.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
This patch has been split off from [0] to facilitate easier merging. I
have still kept it as v3 to maintain continuity with the previous patches.
[0] https://patchwork.linuxtv.org/project/linux-media/list/?series=5526&state=%2A&archive=both
Changes in v3:
- Update commit message to mention that all 64 threads are being added.
Changes in v2:
- Add all 64 threads, instead of having only the one thread being
currently used by the driver.
drivers/dma/ti/k3-psil-j721e.c | 73 ++++++++++++++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c
index 7580870ed746..34e3fc565a37 100644
--- a/drivers/dma/ti/k3-psil-j721e.c
+++ b/drivers/dma/ti/k3-psil-j721e.c
@@ -58,6 +58,14 @@
}, \
}
+#define PSIL_CSI2RX(x) \
+ { \
+ .thread_id = x, \
+ .ep_config = { \
+ .ep_type = PSIL_EP_NATIVE, \
+ }, \
+ }
+
/* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */
static struct psil_ep j721e_src_ep_map[] = {
/* SA2UL */
@@ -138,6 +146,71 @@ static struct psil_ep j721e_src_ep_map[] = {
PSIL_PDMA_XY_PKT(0x4707),
PSIL_PDMA_XY_PKT(0x4708),
PSIL_PDMA_XY_PKT(0x4709),
+ /* CSI2RX */
+ PSIL_CSI2RX(0x4940),
+ PSIL_CSI2RX(0x4941),
+ PSIL_CSI2RX(0x4942),
+ PSIL_CSI2RX(0x4943),
+ PSIL_CSI2RX(0x4944),
+ PSIL_CSI2RX(0x4945),
+ PSIL_CSI2RX(0x4946),
+ PSIL_CSI2RX(0x4947),
+ PSIL_CSI2RX(0x4948),
+ PSIL_CSI2RX(0x4949),
+ PSIL_CSI2RX(0x494a),
+ PSIL_CSI2RX(0x494b),
+ PSIL_CSI2RX(0x494c),
+ PSIL_CSI2RX(0x494d),
+ PSIL_CSI2RX(0x494e),
+ PSIL_CSI2RX(0x494f),
+ PSIL_CSI2RX(0x4950),
+ PSIL_CSI2RX(0x4951),
+ PSIL_CSI2RX(0x4952),
+ PSIL_CSI2RX(0x4953),
+ PSIL_CSI2RX(0x4954),
+ PSIL_CSI2RX(0x4955),
+ PSIL_CSI2RX(0x4956),
+ PSIL_CSI2RX(0x4957),
+ PSIL_CSI2RX(0x4958),
+ PSIL_CSI2RX(0x4959),
+ PSIL_CSI2RX(0x495a),
+ PSIL_CSI2RX(0x495b),
+ PSIL_CSI2RX(0x495c),
+ PSIL_CSI2RX(0x495d),
+ PSIL_CSI2RX(0x495e),
+ PSIL_CSI2RX(0x495f),
+ PSIL_CSI2RX(0x4960),
+ PSIL_CSI2RX(0x4961),
+ PSIL_CSI2RX(0x4962),
+ PSIL_CSI2RX(0x4963),
+ PSIL_CSI2RX(0x4964),
+ PSIL_CSI2RX(0x4965),
+ PSIL_CSI2RX(0x4966),
+ PSIL_CSI2RX(0x4967),
+ PSIL_CSI2RX(0x4968),
+ PSIL_CSI2RX(0x4969),
+ PSIL_CSI2RX(0x496a),
+ PSIL_CSI2RX(0x496b),
+ PSIL_CSI2RX(0x496c),
+ PSIL_CSI2RX(0x496d),
+ PSIL_CSI2RX(0x496e),
+ PSIL_CSI2RX(0x496f),
+ PSIL_CSI2RX(0x4970),
+ PSIL_CSI2RX(0x4971),
+ PSIL_CSI2RX(0x4972),
+ PSIL_CSI2RX(0x4973),
+ PSIL_CSI2RX(0x4974),
+ PSIL_CSI2RX(0x4975),
+ PSIL_CSI2RX(0x4976),
+ PSIL_CSI2RX(0x4977),
+ PSIL_CSI2RX(0x4978),
+ PSIL_CSI2RX(0x4979),
+ PSIL_CSI2RX(0x497a),
+ PSIL_CSI2RX(0x497b),
+ PSIL_CSI2RX(0x497c),
+ PSIL_CSI2RX(0x497d),
+ PSIL_CSI2RX(0x497e),
+ PSIL_CSI2RX(0x497f),
/* CPSW9 */
PSIL_ETHERNET(0x4a00),
/* CPSW0 */
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX
2021-06-24 18:24 [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav
@ 2021-06-28 10:38 ` Péter Ujfalusi
2021-06-28 10:58 ` Pratyush Yadav
0 siblings, 1 reply; 4+ messages in thread
From: Péter Ujfalusi @ 2021-06-28 10:38 UTC (permalink / raw)
To: Pratyush Yadav; +Cc: Vinod Koul, dmaengine, linux-kernel
On 24/06/2021 21:24, Pratyush Yadav wrote:
> The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory.
If we want to be correct:
The CSI2RX subsystem in j721e is serviced by UDMA via PSI-L to transfer
frames to memory.
If you update the commit message you can also add my:
Acked-by: Peter Ujfalusi <peter.ujflausi@gmail.com>
> It can
> have up to 32 threads per instance. J721E has two instances of the
> subsystem, so there are 64 threads total. Add them to the endpoint map.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
>
> ---
> This patch has been split off from [0] to facilitate easier merging. I
> have still kept it as v3 to maintain continuity with the previous patches.
>
> [0] https://patchwork.linuxtv.org/project/linux-media/list/?series=5526&state=%2A&archive=both
>
> Changes in v3:
> - Update commit message to mention that all 64 threads are being added.
>
> Changes in v2:
> - Add all 64 threads, instead of having only the one thread being
> currently used by the driver.
>
> drivers/dma/ti/k3-psil-j721e.c | 73 ++++++++++++++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c
> index 7580870ed746..34e3fc565a37 100644
> --- a/drivers/dma/ti/k3-psil-j721e.c
> +++ b/drivers/dma/ti/k3-psil-j721e.c
> @@ -58,6 +58,14 @@
> }, \
> }
>
> +#define PSIL_CSI2RX(x) \
> + { \
> + .thread_id = x, \
> + .ep_config = { \
> + .ep_type = PSIL_EP_NATIVE, \
> + }, \
> + }
> +
> /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */
> static struct psil_ep j721e_src_ep_map[] = {
> /* SA2UL */
> @@ -138,6 +146,71 @@ static struct psil_ep j721e_src_ep_map[] = {
> PSIL_PDMA_XY_PKT(0x4707),
> PSIL_PDMA_XY_PKT(0x4708),
> PSIL_PDMA_XY_PKT(0x4709),
> + /* CSI2RX */
> + PSIL_CSI2RX(0x4940),
> + PSIL_CSI2RX(0x4941),
> + PSIL_CSI2RX(0x4942),
> + PSIL_CSI2RX(0x4943),
> + PSIL_CSI2RX(0x4944),
> + PSIL_CSI2RX(0x4945),
> + PSIL_CSI2RX(0x4946),
> + PSIL_CSI2RX(0x4947),
> + PSIL_CSI2RX(0x4948),
> + PSIL_CSI2RX(0x4949),
> + PSIL_CSI2RX(0x494a),
> + PSIL_CSI2RX(0x494b),
> + PSIL_CSI2RX(0x494c),
> + PSIL_CSI2RX(0x494d),
> + PSIL_CSI2RX(0x494e),
> + PSIL_CSI2RX(0x494f),
> + PSIL_CSI2RX(0x4950),
> + PSIL_CSI2RX(0x4951),
> + PSIL_CSI2RX(0x4952),
> + PSIL_CSI2RX(0x4953),
> + PSIL_CSI2RX(0x4954),
> + PSIL_CSI2RX(0x4955),
> + PSIL_CSI2RX(0x4956),
> + PSIL_CSI2RX(0x4957),
> + PSIL_CSI2RX(0x4958),
> + PSIL_CSI2RX(0x4959),
> + PSIL_CSI2RX(0x495a),
> + PSIL_CSI2RX(0x495b),
> + PSIL_CSI2RX(0x495c),
> + PSIL_CSI2RX(0x495d),
> + PSIL_CSI2RX(0x495e),
> + PSIL_CSI2RX(0x495f),
> + PSIL_CSI2RX(0x4960),
> + PSIL_CSI2RX(0x4961),
> + PSIL_CSI2RX(0x4962),
> + PSIL_CSI2RX(0x4963),
> + PSIL_CSI2RX(0x4964),
> + PSIL_CSI2RX(0x4965),
> + PSIL_CSI2RX(0x4966),
> + PSIL_CSI2RX(0x4967),
> + PSIL_CSI2RX(0x4968),
> + PSIL_CSI2RX(0x4969),
> + PSIL_CSI2RX(0x496a),
> + PSIL_CSI2RX(0x496b),
> + PSIL_CSI2RX(0x496c),
> + PSIL_CSI2RX(0x496d),
> + PSIL_CSI2RX(0x496e),
> + PSIL_CSI2RX(0x496f),
> + PSIL_CSI2RX(0x4970),
> + PSIL_CSI2RX(0x4971),
> + PSIL_CSI2RX(0x4972),
> + PSIL_CSI2RX(0x4973),
> + PSIL_CSI2RX(0x4974),
> + PSIL_CSI2RX(0x4975),
> + PSIL_CSI2RX(0x4976),
> + PSIL_CSI2RX(0x4977),
> + PSIL_CSI2RX(0x4978),
> + PSIL_CSI2RX(0x4979),
> + PSIL_CSI2RX(0x497a),
> + PSIL_CSI2RX(0x497b),
> + PSIL_CSI2RX(0x497c),
> + PSIL_CSI2RX(0x497d),
> + PSIL_CSI2RX(0x497e),
> + PSIL_CSI2RX(0x497f),
> /* CPSW9 */
> PSIL_ETHERNET(0x4a00),
> /* CPSW0 */
>
--
Péter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX
2021-06-28 10:38 ` Péter Ujfalusi
@ 2021-06-28 10:58 ` Pratyush Yadav
2021-07-01 7:13 ` Péter Ujfalusi
0 siblings, 1 reply; 4+ messages in thread
From: Pratyush Yadav @ 2021-06-28 10:58 UTC (permalink / raw)
To: Péter Ujfalusi; +Cc: Vinod Koul, dmaengine, linux-kernel
On 28/06/21 01:38PM, Péter Ujfalusi wrote:
>
>
> On 24/06/2021 21:24, Pratyush Yadav wrote:
> > The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory.
>
> If we want to be correct:
> The CSI2RX subsystem in j721e is serviced by UDMA via PSI-L to transfer
> frames to memory.
>
> If you update the commit message you can also add my:
Ah, I thought you were picking the patch up. Does Vinod pick them up
instead?
Vinod,
Can you update the commit message when applying or do you want me to
send another re-roll?
>
> Acked-by: Peter Ujfalusi <peter.ujflausi@gmail.com>
>
> > It can
> > have up to 32 threads per instance. J721E has two instances of the
> > subsystem, so there are 64 threads total. Add them to the endpoint map.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> >
> > ---
> > This patch has been split off from [0] to facilitate easier merging. I
> > have still kept it as v3 to maintain continuity with the previous patches.
> >
> > [0] https://patchwork.linuxtv.org/project/linux-media/list/?series=5526&state=%2A&archive=both
> >
> > Changes in v3:
> > - Update commit message to mention that all 64 threads are being added.
> >
> > Changes in v2:
> > - Add all 64 threads, instead of having only the one thread being
> > currently used by the driver.
> >
> > drivers/dma/ti/k3-psil-j721e.c | 73 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> >
> > diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c
> > index 7580870ed746..34e3fc565a37 100644
> > --- a/drivers/dma/ti/k3-psil-j721e.c
> > +++ b/drivers/dma/ti/k3-psil-j721e.c
> > @@ -58,6 +58,14 @@
> > }, \
> > }
> >
> > +#define PSIL_CSI2RX(x) \
> > + { \
> > + .thread_id = x, \
> > + .ep_config = { \
> > + .ep_type = PSIL_EP_NATIVE, \
> > + }, \
> > + }
> > +
> > /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */
> > static struct psil_ep j721e_src_ep_map[] = {
> > /* SA2UL */
> > @@ -138,6 +146,71 @@ static struct psil_ep j721e_src_ep_map[] = {
> > PSIL_PDMA_XY_PKT(0x4707),
> > PSIL_PDMA_XY_PKT(0x4708),
> > PSIL_PDMA_XY_PKT(0x4709),
> > + /* CSI2RX */
> > + PSIL_CSI2RX(0x4940),
> > + PSIL_CSI2RX(0x4941),
> > + PSIL_CSI2RX(0x4942),
> > + PSIL_CSI2RX(0x4943),
> > + PSIL_CSI2RX(0x4944),
> > + PSIL_CSI2RX(0x4945),
> > + PSIL_CSI2RX(0x4946),
> > + PSIL_CSI2RX(0x4947),
> > + PSIL_CSI2RX(0x4948),
> > + PSIL_CSI2RX(0x4949),
> > + PSIL_CSI2RX(0x494a),
> > + PSIL_CSI2RX(0x494b),
> > + PSIL_CSI2RX(0x494c),
> > + PSIL_CSI2RX(0x494d),
> > + PSIL_CSI2RX(0x494e),
> > + PSIL_CSI2RX(0x494f),
> > + PSIL_CSI2RX(0x4950),
> > + PSIL_CSI2RX(0x4951),
> > + PSIL_CSI2RX(0x4952),
> > + PSIL_CSI2RX(0x4953),
> > + PSIL_CSI2RX(0x4954),
> > + PSIL_CSI2RX(0x4955),
> > + PSIL_CSI2RX(0x4956),
> > + PSIL_CSI2RX(0x4957),
> > + PSIL_CSI2RX(0x4958),
> > + PSIL_CSI2RX(0x4959),
> > + PSIL_CSI2RX(0x495a),
> > + PSIL_CSI2RX(0x495b),
> > + PSIL_CSI2RX(0x495c),
> > + PSIL_CSI2RX(0x495d),
> > + PSIL_CSI2RX(0x495e),
> > + PSIL_CSI2RX(0x495f),
> > + PSIL_CSI2RX(0x4960),
> > + PSIL_CSI2RX(0x4961),
> > + PSIL_CSI2RX(0x4962),
> > + PSIL_CSI2RX(0x4963),
> > + PSIL_CSI2RX(0x4964),
> > + PSIL_CSI2RX(0x4965),
> > + PSIL_CSI2RX(0x4966),
> > + PSIL_CSI2RX(0x4967),
> > + PSIL_CSI2RX(0x4968),
> > + PSIL_CSI2RX(0x4969),
> > + PSIL_CSI2RX(0x496a),
> > + PSIL_CSI2RX(0x496b),
> > + PSIL_CSI2RX(0x496c),
> > + PSIL_CSI2RX(0x496d),
> > + PSIL_CSI2RX(0x496e),
> > + PSIL_CSI2RX(0x496f),
> > + PSIL_CSI2RX(0x4970),
> > + PSIL_CSI2RX(0x4971),
> > + PSIL_CSI2RX(0x4972),
> > + PSIL_CSI2RX(0x4973),
> > + PSIL_CSI2RX(0x4974),
> > + PSIL_CSI2RX(0x4975),
> > + PSIL_CSI2RX(0x4976),
> > + PSIL_CSI2RX(0x4977),
> > + PSIL_CSI2RX(0x4978),
> > + PSIL_CSI2RX(0x4979),
> > + PSIL_CSI2RX(0x497a),
> > + PSIL_CSI2RX(0x497b),
> > + PSIL_CSI2RX(0x497c),
> > + PSIL_CSI2RX(0x497d),
> > + PSIL_CSI2RX(0x497e),
> > + PSIL_CSI2RX(0x497f),
> > /* CPSW9 */
> > PSIL_ETHERNET(0x4a00),
> > /* CPSW0 */
> >
>
> --
> Péter
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX
2021-06-28 10:58 ` Pratyush Yadav
@ 2021-07-01 7:13 ` Péter Ujfalusi
0 siblings, 0 replies; 4+ messages in thread
From: Péter Ujfalusi @ 2021-07-01 7:13 UTC (permalink / raw)
To: Pratyush Yadav; +Cc: Vinod Koul, dmaengine, linux-kernel
On 28/06/2021 13:58, Pratyush Yadav wrote:
> On 28/06/21 01:38PM, Péter Ujfalusi wrote:
>>
>>
>> On 24/06/2021 21:24, Pratyush Yadav wrote:
>>> The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory.
>>
>> If we want to be correct:
>> The CSI2RX subsystem in j721e is serviced by UDMA via PSI-L to transfer
>> frames to memory.
>>
>> If you update the commit message you can also add my:
>
> Ah, I thought you were picking the patch up. Does Vinod pick them up
> instead?
Yes.
> Vinod,
>
> Can you update the commit message when applying or do you want me to
> send another re-roll?
I would send v4 if I were you. Maintainers are under heavy load most of
the time.
--
Péter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-01 7:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-24 18:24 [PATCH v3] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav
2021-06-28 10:38 ` Péter Ujfalusi
2021-06-28 10:58 ` Pratyush Yadav
2021-07-01 7:13 ` Péter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox