Re: [PATCH v12 2/4] dmaengine: tegra: Add tegra gpcdma driver

kernel test robot
2021-11-12T19:11:24Z

[-- Attachment #1: Type: text/plain, Size: 4943 bytes --]

Hi Akhil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on vkoul-dmaengine/next arm64/for-next/core v5.15 next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Akhil-R/dt-bindings-dmaengine-Add-doc-for-tegra-gpcdma/20211109-233646
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/faf61a8fc90e3ea731c65a8cebce3eb6c0444d21
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Akhil-R/dt-bindings-dmaengine-Add-doc-for-tegra-gpcdma/20211109-233646
git checkout faf61a8fc90e3ea731c65a8cebce3eb6c0444d21
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/dma/tegra186-gpc-dma.c: In function 'tegra_dma_sid_free':
>> drivers/dma/tegra186-gpc-dma.c:326:9: error: enumeration value 'DMA_MEM_TO_MEM' not handled in switch [-Werror=switch]
326 | switch (tdc->sid_dir) {
| ^~~~~~
>> drivers/dma/tegra186-gpc-dma.c:326:9: error: enumeration value 'DMA_DEV_TO_DEV' not handled in switch [-Werror=switch]
>> drivers/dma/tegra186-gpc-dma.c:326:9: error: enumeration value 'DMA_TRANS_NONE' not handled in switch [-Werror=switch]
drivers/dma/tegra186-gpc-dma.c: In function 'tegra_dma_reset_client':
>> drivers/dma/tegra186-gpc-dma.c:55:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
55 | FIELD_PREP(TEGRA_GPCDMA_CSR_REQ_SEL_MASK, 4)
| ^~~~~~~~~~
drivers/dma/tegra186-gpc-dma.c:535:16: note: in expansion of macro 'TEGRA_GPCDMA_CSR_REQ_SEL_UNUSED'
535 | csr |= TEGRA_GPCDMA_CSR_REQ_SEL_UNUSED;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/dma/tegra186-gpc-dma.c: In function 'tegra_dma_prep_dma_memset':
>> drivers/dma/tegra186-gpc-dma.c:787:74: error: right shift count >= width of type [-Werror=shift-count-overflow]
787 | FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (dest >> 32));
| ^~
drivers/dma/tegra186-gpc-dma.c: In function 'tegra_dma_prep_dma_memcpy':
drivers/dma/tegra186-gpc-dma.c:854:65: error: right shift count >= width of type [-Werror=shift-count-overflow]
854 | FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_SRC_PTR, (src >> 32));
| ^~
drivers/dma/tegra186-gpc-dma.c:856:66: error: right shift count >= width of type [-Werror=shift-count-overflow]
856 | FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (dest >> 32));
| ^~
drivers/dma/tegra186-gpc-dma.c: In function 'tegra_dma_prep_slave_sg':
drivers/dma/tegra186-gpc-dma.c:962:81: error: right shift count >= width of type [-Werror=shift-count-overflow]
962 | FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_SRC_PTR, (mem >> 32));
| ^~
drivers/dma/tegra186-gpc-dma.c:967:81: error: right shift count >= width of type [-Werror=shift-count-overflow]
967 | FIELD_PREP(TEGRA_GPCDMA_HIGH_ADDR_DST_PTR, (mem >> 32));
| ^~
cc1: all warnings being treated as errors

vim +/DMA_MEM_TO_MEM +326 drivers/dma/tegra186-gpc-dma.c

320
321 static void tegra_dma_sid_free(struct tegra_dma_channel *tdc)
322 {
323 struct tegra_dma *tdma = tdc->tdma;
324 unsigned int sid = tdc->slave_id;
325
> 326 switch (tdc->sid_dir) {
327 case DMA_MEM_TO_DEV:
328 clear_bit(sid, &tdma->sid_m2d_reserved);
329 break;
330 case DMA_DEV_TO_MEM:
331 clear_bit(sid, &tdma->sid_d2m_reserved);
332 break;
333 }
334
335 tdc->sid_dir = DMA_TRANS_NONE;
336 }
337

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61588 bytes --]