RE: [PATCH v13 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma

Akhil R
2021-11-29T05:03:11Z

> On Mon, Nov 22, 2021 at 02:58:09PM +0530, Akhil R wrote:
> > Add DT binding document for Nvidia Tegra GPCDMA controller.
> >
> > Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com>
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> > ---
> > .../bindings/dma/nvidia,tegra186-gpc-dma.yaml | 111
> +++++++++++++++++++++
> > 1 file changed, 111 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > new file mode 100644
> > index 0000000..3a5a70d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya
> > +++ ml
> > @@ -0,0 +1,111 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/dma/nvidia,tegra186-gpc-dma.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra GPC DMA Controller Device Tree Bindings
> > +
> > +description: |
> > + The Tegra General Purpose Central (GPC) DMA controller is used for
> > +faster
> > + data transfers between memory to memory, memory to device and
> > +device to
> > + memory.
> > +
> > +maintainers:
> > + - Jon Hunter <jonathanh@nvidia.com>
> > + - Rajesh Gumasta <rgumasta@nvidia.com>
> > +
> > +allOf:
> > + - $ref: "dma-controller.yaml#"
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: nvidia,tegra186-gpcdma
> > + - items:
> > + - const: nvidia,tegra186-gpcdma
> > + - const: nvidia,tegra194-gpcdma
>
> Still not how 'compatible' works nor what I wrote out for you.
I thought '186' and '194' got interchanged in your previous comment because it is 194
which is the superset of 186 and have got more features than 186.
Or probably I did not understand the idea correctly yet.