Re: [patch 33/37] iommu/arm-smmu-v3: Use msi_get_virq()

Thomas Gleixner
2021-11-29T14:15:33Z

Will,

On Mon, Nov 29 2021 at 10:55, Will Deacon wrote:
> On Sat, Nov 27, 2021 at 02:20:59AM +0100, Thomas Gleixner wrote:
>> + smmu->evtq.q.irq = msi_get_virq(dev, EVTQ_MSI_INDEX);
>> + smmu->gerr_irq = msi_get_virq(dev, GERROR_MSI_INDEX);
>> + smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX);
>
> Prviously, if retrieval of the MSI failed then we'd fall back to wired
> interrupts. Now, I think we'll clobber the interrupt with 0 instead. Can
> we make the assignments to smmu->*irq here conditional on the MSI being
> valid, please?

So the wired irq number is in ->irq already and MSI does an override
if available. Not really obvious...

Thanks,

tglx