From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18BBC433F5 for ; Fri, 1 Apr 2022 12:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345705AbiDAMDh (ORCPT ); Fri, 1 Apr 2022 08:03:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233112AbiDAMDh (ORCPT ); Fri, 1 Apr 2022 08:03:37 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89B4226A940 for ; Fri, 1 Apr 2022 05:01:47 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naFyE-0001Oy-0a; Fri, 01 Apr 2022 14:01:38 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1naFyD-0007yd-3A; Fri, 01 Apr 2022 14:01:37 +0200 Date: Fri, 1 Apr 2022 14:01:37 +0200 From: Sascha Hauer To: Vinod Koul Cc: alsa-devel@alsa-project.org, Xiubo Li , Fabio Estevam , Shengjiu Wang , kernel@pengutronix.de, NXP Linux Team , dmaengine@vger.kernel.org Subject: Re: [PATCH v2 10/19] dma: imx-sdma: Add multi fifo support Message-ID: <20220401120137.GK4012@pengutronix.de> References: <20220328112744.1575631-1-s.hauer@pengutronix.de> <20220328112744.1575631-11-s.hauer@pengutronix.de> <20220331064903.GC4012@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:58:17 up 2 days, 27 min, 56 users, load average: 0.01, 0.05, 0.07 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Mar 31, 2022 at 12:24:46PM +0530, Vinod Koul wrote: > On 31-03-22, 08:49, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 10:56:09AM +0530, Vinod Koul wrote: > > > On 28-03-22, 13:27, Sascha Hauer wrote: > > > > Signed-off-by: Sascha Hauer > > > > > > it is dmaengine: xxx > > > > Ok. > > > > > > > > Also is this patch dependent on rest of the series, if not consider > > > sending separately > > > > The rest of this series indeed depends on this patch. > > > > > > > > > diff --git a/include/linux/platform_data/dma-imx.h b/include/linux/platform_data/dma-imx.h > > > > index 281adbb26e6bd..4a43a048e1b4d 100644 > > > > --- a/include/linux/platform_data/dma-imx.h > > > > +++ b/include/linux/platform_data/dma-imx.h > > > > @@ -39,6 +39,7 @@ enum sdma_peripheral_type { > > > > IMX_DMATYPE_SSI_DUAL, /* SSI Dual FIFO */ > > > > IMX_DMATYPE_ASRC_SP, /* Shared ASRC */ > > > > IMX_DMATYPE_SAI, /* SAI */ > > > > + IMX_DMATYPE_MULTI_SAI, /* MULTI FIFOs For Audio */ > > > > }; > > > > > > > > enum imx_dma_prio { > > > > @@ -65,4 +66,10 @@ static inline int imx_dma_is_general_purpose(struct dma_chan *chan) > > > > !strcmp(chan->device->dev->driver->name, "imx-dma"); > > > > } > > > > > > > > +struct sdma_peripheral_config { > > > > + int n_fifos_src; > > > > + int n_fifos_dst; > > > > + bool sw_done; > > > > +}; > > > > > > Not more platform data :( > > > > I'm not sure what you are referring to as platform_data. This is not the > > classical platform_data that is attached to a platform_device to > > configure behaviour of that device. It is rather data that needs to be > > communicated from the clients of the SDMA engine to the SDMA engine. > > > > I have put this into include/linux/platform_data/dma-imx.h because > > that's the only existing include file that is available. I could move > > this to a new file if you like that better. > > Lets move to include/linux/dma/ What about the other stuff in include/linux/platform_data/dma-imx.h, should this go to include/linux/dma/ as well? There is nothing in it that is platform_data at all. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |