DMA Engine development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mark Hounschell <markh@compro.net>
Cc: Christoph Hellwig <hch@lst.de>,
	Robin Murphy <robin.murphy@arm.com>,
	Linux-kernel <linux-kernel@vger.kernel.org>,
	dmaengine@vger.kernel.org
Subject: Re: [BUG] dma-mapping: remove CONFIG_DMA_REMAP
Date: Tue, 21 Jun 2022 16:19:24 +0200	[thread overview]
Message-ID: <20220621141924.GA8348@lst.de> (raw)
In-Reply-To: <9de341bc-fe8d-1820-187a-46455e4b9bf2@compro.net>

On Tue, Jun 21, 2022 at 10:06:59AM -0400, Mark Hounschell wrote:
> On 6/21/22 09:48, Christoph Hellwig wrote:
>> On Tue, Jun 21, 2022 at 09:43:18AM -0400, Mark Hounschell wrote:
>>> Revert that commit and all works like normal. This commit breaks user land.
>>
>> No.  We had that discussion before.  It exposeѕ how broken your out of
>> tree driver is, which you don't bother to fix despite Robin even taking
>> the pains to explain you how.
>
> No, this is not the original issue and we never actually had a discussion. 
> That original issue was about using Set/ClearPageReserved. You nor Robin 
> even tried to explain why it was wrong to use it. It was never an issue in 
> previous kernels. Why now? In any case I have removed that code. This is 
> what happens now.
>
> What is it you think I am doing wrong. Except for using 
> Set/ClearPageReserved you have not explained anything to me.

Which part of "you must not call virt_to_page on the result that is
very clearly stated in the documentation and has been explained to
you repeatly" is still not clear to you?

Which part of "if your of tree modules stops working, this does not
constitute userspace breakage" is not clear to you?

I'm done with this, please stop bothering me.

  reply	other threads:[~2022-06-21 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 13:43 [BUG] dma-mapping: remove CONFIG_DMA_REMAP Mark Hounschell
2022-06-21 13:48 ` Christoph Hellwig
2022-06-21 14:06   ` Mark Hounschell
2022-06-21 14:19     ` Christoph Hellwig [this message]
2022-06-21 14:31       ` Mark Hounschell
2022-06-21 14:51 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621141924.GA8348@lst.de \
    --to=hch@lst.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox