From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Vinod Koul <vkoul@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed
Date: Fri, 22 Jul 2022 10:21:57 +0200 [thread overview]
Message-ID: <20220722082157.fbbwfv4ppsisjqax@pengutronix.de> (raw)
In-Reply-To: <20220721204054.323602-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Thu, Jul 21, 2022 at 10:40:54PM +0200, Uwe Kleine-König wrote:
> It's not allowed to quit remove early without cleaning up completely.
> Otherwise this results in resource leaks that probably yield graver
> problems later. Here for example some tasklets might survive the lifetime
> of the sprd-dma device and access sdev which is freed after .remove()
> returns.
>
> As none of the device freeing requires an active device, just ignore the
> return value of pm_runtime_get_sync().
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
If you want a fixes line, that would be:
Fixes: 9b3b8171f7f4 ("dmaengine: sprd: Add Spreadtrum DMA driver")
but I'm not sure this is critical enough to be backported to stable. So
apply at will.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-22 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 20:40 [PATCH] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed Uwe Kleine-König
2022-07-22 1:36 ` Baolin Wang
2022-07-22 8:21 ` Uwe Kleine-König [this message]
2022-07-26 12:51 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722082157.fbbwfv4ppsisjqax@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=baolin.wang7@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=orsonzhai@gmail.com \
--cc=vkoul@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox