From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Robin Murphy <robin.murphy@arm.com>,
Jingoo Han <jingoohan1@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Krzysztof Wilczyński" <kw@linux.com>,
caihuoqing <caihuoqing@baidu.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v8 20/26] dmaengine: dw-edma: Drop DT-region allocation
Date: Mon, 19 Dec 2022 17:46:51 +0300 [thread overview]
Message-ID: <20221219144658.26620-21-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20221219144658.26620-1-Sergey.Semin@baikalelectronics.ru>
There is no point in allocating an additional memory for the data target
regions passed then to the client drivers. Just use the already available
structures defined in the dw_edma_chip instance.
Note these regions are unused in normal circumstances since they are
specific to the case of eDMA being embedded into the DW PCIe End-point and
having it's CSRs accessible over a End-point' BAR. This case is only known
to be implemented as a part of the Synopsys PCIe EndPoint IP prototype
kit.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/dw-edma/dw-edma-core.c | 21 ++++-----------------
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 58808bec4148..040a88cfe070 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -738,7 +738,6 @@ static void dw_edma_free_chan_resources(struct dma_chan *dchan)
static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
{
struct dw_edma_chip *chip = dw->chip;
- struct dw_edma_region *dt_region;
struct device *dev = chip->dev;
struct dw_edma_chan *chan;
struct dw_edma_irq *irq;
@@ -754,12 +753,6 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
for (i = 0; i < ch_cnt; i++) {
chan = &dw->chan[i];
- dt_region = devm_kzalloc(dev, sizeof(*dt_region), GFP_KERNEL);
- if (!dt_region)
- return -ENOMEM;
-
- chan->vc.chan.private = dt_region;
-
chan->dw = dw;
if (i < dw->wr_ch_cnt) {
@@ -807,17 +800,11 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
chan->msi.data);
chan->vc.desc_free = vchan_free_desc;
- vchan_init(&chan->vc, dma);
+ chan->vc.chan.private = chan->dir == EDMA_DIR_WRITE ?
+ &dw->chip->dt_region_wr[chan->id] :
+ &dw->chip->dt_region_rd[chan->id];
- if (chan->dir == EDMA_DIR_WRITE) {
- dt_region->paddr = chip->dt_region_wr[chan->id].paddr;
- dt_region->vaddr = chip->dt_region_wr[chan->id].vaddr;
- dt_region->sz = chip->dt_region_wr[chan->id].sz;
- } else {
- dt_region->paddr = chip->dt_region_rd[chan->id].paddr;
- dt_region->vaddr = chip->dt_region_rd[chan->id].vaddr;
- dt_region->sz = chip->dt_region_rd[chan->id].sz;
- }
+ vchan_init(&chan->vc, dma);
dw_edma_v0_core_device_config(chan);
}
--
2.38.1
next prev parent reply other threads:[~2022-12-19 14:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 14:46 [PATCH v8 00/26] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-12-19 14:46 ` [PATCH v8 01/26] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-12-19 14:46 ` [PATCH v8 02/26] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-12-19 14:46 ` [PATCH v8 03/26] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-12-19 14:46 ` [PATCH v8 04/26] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-12-19 14:46 ` [PATCH v8 05/26] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-12-19 14:46 ` [PATCH v8 06/26] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-12-19 14:46 ` [PATCH v8 07/26] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-12-19 14:46 ` [PATCH v8 08/26] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-12-19 14:46 ` [PATCH v8 09/26] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-12-19 14:46 ` [PATCH v8 10/26] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-12-19 14:46 ` [PATCH v8 11/26] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-12-19 14:46 ` [PATCH v8 12/26] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-12-19 14:46 ` [PATCH v8 13/26] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-12-19 14:46 ` [PATCH v8 14/26] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-12-19 14:46 ` [PATCH v8 15/26] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-12-19 14:46 ` [PATCH v8 16/26] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-12-19 14:46 ` [PATCH v8 17/26] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-12-19 14:46 ` [PATCH v8 18/26] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-12-19 14:46 ` [PATCH v8 19/26] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-12-19 14:46 ` Serge Semin [this message]
2022-12-19 14:46 ` [PATCH v8 21/26] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-12-19 14:46 ` [PATCH v8 22/26] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-12-19 14:46 ` [PATCH v8 23/26] dmaengine: dw-edma: Relax driver config settings Serge Semin
2022-12-19 14:46 ` [PATCH v8 24/26] PCI: dwc: Set coherent DMA-mask on MSI-address allocation Serge Semin
2023-01-11 13:39 ` Robin Murphy
2023-01-12 18:46 ` Serge Semin
2022-12-19 14:46 ` [PATCH v8 25/26] PCI: bt1: Set 64-bit DMA-mask Serge Semin
2022-12-19 14:46 ` [PATCH v8 26/26] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-12-20 3:01 ` kernel test robot
2023-01-11 13:03 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219144658.26620-21-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=caihuoqing@baidu.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox