From: Serge Semin <fancer.lancer@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Cai Huoqing" <cai.huoqing@linux.dev>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dmaengine: dw-edma: Add support for native HDMA
Date: Thu, 2 Mar 2023 23:30:17 +0300 [thread overview]
Message-ID: <20230302203017.jdqsfu5iauw2pp22@mobilestation> (raw)
In-Reply-To: <b108f61d-e812-a500-0c8f-4fb1acd44ca2@metafoo.de>
Hi Lars
On Thu, Mar 02, 2023 at 09:26:51AM -0800, Lars-Peter Clausen wrote:
> On 2/20/23 19:46, Cai Huoqing wrote:
> > +void dw_hdma_v0_core_register(struct dw_edma *dw)
> > +{
> > + dw->core = &dw_hdma_v0_core;
> > +}
>
> Where is dw_hdma_v0_core_register() called?
Indeed. Good catch! The respective change has been missing since v2:
@@ -952,7 +953,10 @@ int dw_edma_probe(struct dw_edma_chip *chip)
dw->chip = chip;
- dw_edma_v0_core_register(dw);
+ if (dw->chip->mf == EDMA_MF_HDMA_NATIVE)
+ dw_hdma_v0_core_register(dw);
+ else
+ dw_edma_v0_core_register(dw);
@Cai, please fix that.
-Serge(y)
>
>
next prev parent reply other threads:[~2023-03-02 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 3:46 [PATCH v4 0/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-02-21 3:46 ` [PATCH v4 1/4] dmaengine: dw-edma: Rename dw_edma_core_ops structure to dw_edma_plat_ops Cai Huoqing
2023-03-02 19:49 ` Serge Semin
2023-02-21 3:46 ` [PATCH v4 2/4] dmaengine: dw-edma: Create a new dw_edma_core_ops structure to abstract controller operation Cai Huoqing
2023-03-02 20:17 ` Serge Semin
2023-02-21 3:46 ` [PATCH v4 3/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-03-02 17:26 ` Lars-Peter Clausen
2023-03-02 20:30 ` Serge Semin [this message]
2023-03-02 20:43 ` Serge Semin
2023-03-03 13:00 ` Cai Huoqing
2023-03-03 16:02 ` Serge Semin
2023-02-21 3:46 ` [PATCH v4 4/4] dmaengine: dw-edma: Add HDMA DebugFS support Cai Huoqing
2023-03-02 21:04 ` Serge Semin
2023-03-01 2:22 ` [PATCH v4 0/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302203017.jdqsfu5iauw2pp22@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox