From: Jisheng Zhang <jszhang@kernel.org>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/11] dmaengine: dw-axi-dmac: support polled mode
Date: Tue, 14 Mar 2023 01:04:50 +0800 [thread overview]
Message-ID: <20230313170450.897-12-jszhang@kernel.org> (raw)
In-Reply-To: <20230313170450.897-1-jszhang@kernel.org>
Run in polled mode if the DMA_PREP_INTERRUPT flag is not provided.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 11 ++++++++++-
drivers/dma/dw-axi-dmac/dw-axi-dmac.h | 1 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 1d00793a83bf..8daeb22d4560 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -383,7 +383,10 @@ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
write_chan_llp(chan, first->hw_desc[0].llp | lms);
irq_mask = DWAXIDMAC_IRQ_DMA_TRF | DWAXIDMAC_IRQ_ALL_ERR;
- axi_chan_irq_sig_set(chan, irq_mask);
+ if (chan->polled)
+ axi_chan_irq_sig_set(chan, DWAXIDMAC_IRQ_NONE);
+ else
+ axi_chan_irq_sig_set(chan, irq_mask);
/* Generate 'suspend' status but don't generate interrupt */
irq_mask |= DWAXIDMAC_IRQ_SUSPENDED;
@@ -714,6 +717,7 @@ dw_axi_dma_chan_prep_cyclic(struct dma_chan *dchan, dma_addr_t dma_addr,
if (unlikely(!desc))
goto err_desc_get;
+ chan->polled = !(flags & DMA_PREP_INTERRUPT);
chan->direction = direction;
desc->chan = chan;
chan->cyclic = true;
@@ -796,6 +800,7 @@ dw_axi_dma_chan_prep_slave_sg(struct dma_chan *dchan, struct scatterlist *sgl,
desc->chan = chan;
desc->length = 0;
+ chan->polled = !(flags & DMA_PREP_INTERRUPT);
chan->direction = direction;
for_each_sg(sgl, sg, sg_len, i) {
@@ -859,6 +864,7 @@ dma_chan_prep_dma_memcpy(struct dma_chan *dchan, dma_addr_t dst_adr,
if (unlikely(!desc))
goto err_desc_get;
+ chan->polled = !(flags & DMA_PREP_INTERRUPT);
desc->chan = chan;
num = 0;
desc->length = 0;
@@ -1139,6 +1145,9 @@ dma_chan_tx_status(struct dma_chan *dchan, dma_cookie_t cookie,
u32 length;
u32 len;
+ if (chan->polled)
+ dw_axi_dma_handle_ch(chan);
+
status = dma_cookie_status(dchan, cookie, txstate);
if (status == DMA_COMPLETE || !txstate)
return status;
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac.h b/drivers/dma/dw-axi-dmac/dw-axi-dmac.h
index f57961620d2d..e4fbc38446ec 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac.h
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac.h
@@ -54,6 +54,7 @@ struct axi_dma_chan {
bool cyclic;
/* these other elements are all protected by vc.lock */
bool is_paused;
+ bool polled;
};
struct dw_axi_dma {
--
2.39.2
prev parent reply other threads:[~2023-03-13 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 17:04 [PATCH 00/11] dmaengine: dw-axi_dmac: bug fix clean up and more features Jisheng Zhang
2023-03-13 17:04 ` [PATCH 01/11] dmaengine: dw-axi-dmac: fix reading register hen runtime suspended Jisheng Zhang
2023-04-12 17:33 ` Vinod Koul
2023-04-15 10:02 ` Jisheng Zhang
2023-03-13 17:04 ` [PATCH 02/11] dmaengine: dw-axi-dmac: remove unnecessary devm_free_irq() calling Jisheng Zhang
2023-04-12 17:38 ` Vinod Koul
2023-04-15 10:03 ` Jisheng Zhang
2023-03-13 17:04 ` [PATCH 03/11] dmaengine: dw-axi-dmac: remove unnecessary axi_dma_enable() calling Jisheng Zhang
2023-03-13 17:04 ` [PATCH 04/11] dmaengine: dw-axi-dmac: remove redudant axi_dma_disable() calling Jisheng Zhang
2023-04-12 17:36 ` Vinod Koul
2023-03-13 17:04 ` [PATCH 05/11] dmaengine: dw-axi-dmac: delay irq getting until request_irq Jisheng Zhang
2023-03-13 17:04 ` [PATCH 06/11] dmaengine: dw-axi-dmac: move ch irq handling into common routine Jisheng Zhang
2023-03-13 17:04 ` [PATCH 07/11] dmaengine: dw-axi-dmac: support per channel irq Jisheng Zhang
2023-03-13 17:04 ` [PATCH 08/11] dmaengine: dw-axi-dmac: support dma-channel-mask Jisheng Zhang
2023-03-13 17:04 ` [PATCH 09/11] dmaengine: dw-axi-dmac: try best to get residue when tx is running Jisheng Zhang
2023-03-13 17:04 ` [PATCH 10/11] dmaengine: dw-axi-dmac: move dma_chan_tx_status() Jisheng Zhang
2023-03-13 17:04 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313170450.897-12-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).