From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF4FC77B7C for ; Thu, 4 May 2023 21:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229460AbjEDV50 (ORCPT ); Thu, 4 May 2023 17:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbjEDV5Y (ORCPT ); Thu, 4 May 2023 17:57:24 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C94DA13289; Thu, 4 May 2023 14:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683237443; x=1714773443; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4Q0HgYS8fBg0x+XSACWujM6Ax818ZMRS1g2rWv1t5c0=; b=VvKG1F4c+OE3S6VlePVAYkPf8Kpk/l0WVwWcbYi9md4XE2JqIF/sIe6E kaLV+l/4bwQv0N5P/owYKUq8TKRxRQdt8YwNO2RwlO0hfi7jl17+M+O5o C4sLojKmoVpRF0LsszLMBzorflH+y0uw23QwCg+ksFD1m6PHZyRLhLRdA /JaLTw1xKaiTWKRG97+70+zB+RVdYX7EGL5ihjp82Q37N2tAsZdjAcAmv 5zzXDAK72Mc6TCLoi/x+Rci+eKv5r038p+0XlbSjKg3bsrZo2PL6e/pgl bc/1AKkmfgPnIfiZ2VTSrJzrg0iudC0exz1wkPCHK0yWFCgcEcMNjqZZy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="351187040" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="351187040" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 14:23:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="697233794" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="697233794" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.24.100.114]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 14:23:05 -0700 Date: Thu, 4 May 2023 14:27:27 -0700 From: Jacob Pan To: "Tian, Kevin" Cc: LKML , "iommu@lists.linux.dev" , Robin Murphy , Jason Gunthorpe , Lu Baolu , Joerg Roedel , "dmaengine@vger.kernel.org" , "vkoul@kernel.org" , Will Deacon , David Woodhouse , "Raj, Ashok" , "Liu, Yi L" , "Yu, Fenghua" , "Jiang, Dave" , "Luck, Tony" , "Zanussi, Tom" , "Ranganathan, Narayan" , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v5 4/7] iommu/vt-d: Factoring out PASID set up helper function Message-ID: <20230504142727.4bd2206a@jacob-builder> In-Reply-To: References: <20230427174937.471668-1-jacob.jun.pan@linux.intel.com> <20230427174937.471668-5-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Kevin, On Fri, 28 Apr 2023 09:47:45 +0000, "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Friday, April 28, 2023 1:50 AM > > > > > > +static int dmar_domain_attach_device_pasid(struct dmar_domain *domain, > > + struct intel_iommu *iommu, > > + struct device *dev, > > ioasid_t pasid) +{ > > + int ret; > > + > > + /* PASID table is mandatory for a PCI device in scalable mode. > > */ > > + if (!sm_supported(iommu) && dev_is_real_dma_subdevice(dev)) > > + return -EOPNOTSUPP; > > "&&" should be "||" > good catch, Thanks, Jacob