From: Kelvin Cao <kelvin.cao@microchip.com>
To: <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <logang@deltatee.com>, <George.Ge@microchip.com>,
<christophe.jaillet@wanadoo.fr>, <hch@infradead.org>
Subject: [PATCH v6 0/1] Switchtec Switch DMA Engine Driver
Date: Fri, 28 Jul 2023 13:03:26 -0700 [thread overview]
Message-ID: <20230728200327.96496-1-kelvin.cao@microchip.com> (raw)
Hi,
This is v6 of the Switchtec Switch DMA Engine Driver, incorporating
changes for the v2/v3/v4/v5 review comments.
v6 changes:
- Fix './scripts/checkpatch.pl --strict' warnings
- Use readl_poll_timeout_atomic for status checking with timeout
- Wrap enable_channel/disable_channel over channel_op
- Use flag GFP_NOWAIT for mem allocation in switchtec_dma_alloc_desc
- Use proper comment for macro SWITCHTEC_DMA_DEVICE
v5 changes:
- Remove unnecessary structure modifier '__packed'
- Remove the use of union of identical data types in a structure
- Remove unnecessary call sites of synchronize_irq
- Remove unnecessary rcu lock for pdev during device initialization
- Use pci_request_irq/pci_free_irq to replace request_irq/free_irq
- Add mailing list info in file MAINTAINERS
- Miscellaneous cleanups
v4 changes:
- Sort driver entry in drivers/dma/Kconfig and drivers/dma/Makefile
alphabetically
- Fix miscellaneous style issues
- Correct year in copyright
- Add function and call sites to flush PCIe MMIO Write
- Add a helper to wait for status register update
- Move synchronize_irq out of RCU critical section
- Remove unnecessary endianness conversion for register access
- Remove some unused code
- Use pci_enable_device/pci_request_mem_regions instead of
pcim_enable_device/pcim_iomap_regions to make the resource lifetime
management more understandable
- Use offset macros instead of memory mapped structures when accessing
some registers
- Remove the attempt to set DMA mask with smaller number as it would
never succeed if the first attempt with bigger number fails
- Use PCI_VENDOR_ID_MICROSEMI in include/linux/pci_ids.h as device ID
v3 changes:
- Remove some unnecessary memory/variable zeroing
v2 changes:
- Move put_device(dma_dev->dev) before kfree(swdma_dev) as dma_dev is
part of swdma_dev.
- Convert dev_ print calls to pci_ print calls to make the use of
print functions consistent within switchtec_dma_create().
- Remove some dev_ print calls, which use device pointer as handles,
to ensure there's no reference issue when the device is unbound.
- Remove unused .driver_data from pci_device_id structure.
v1:
The following patch implements a DMAEngine driver to use the DMA
controller in Switchtec PSX/PFX switchtes. The DMA controller appears as
a PCI function on the switch upstream port. The DMA function can include
one or more DMA channels.
This patchset is based off of 6.5.0-rc3.
Kelvin Cao (1):
dmaengine: switchtec-dma: Introduce Switchtec DMA engine PCI driver
MAINTAINERS | 6 +
drivers/dma/Kconfig | 9 +
drivers/dma/Makefile | 1 +
drivers/dma/switchtec_dma.c | 1570 +++++++++++++++++++++++++++++++++++
4 files changed, 1586 insertions(+)
create mode 100644 drivers/dma/switchtec_dma.c
--
2.25.1
next reply other threads:[~2023-07-28 21:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 20:03 Kelvin Cao [this message]
2023-07-28 20:03 ` [PATCH v6 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA engine PCI driver Kelvin Cao
2023-07-31 7:08 ` Christoph Hellwig
2023-07-31 23:07 ` Kelvin.Cao
2023-08-01 18:42 ` Vinod Koul
2023-08-03 3:15 ` Kelvin.Cao
2023-08-21 23:44 ` Kelvin.Cao
2023-10-05 18:35 ` Kelvin.Cao
2023-10-06 10:30 ` Vinod Koul
2023-10-06 22:34 ` Kelvin.Cao
2023-10-09 5:38 ` Vinod Koul
2023-10-10 21:23 ` Kelvin.Cao
2023-10-11 11:48 ` Vinod Koul
2023-10-11 16:36 ` Kelvin.Cao
2023-10-23 17:14 ` Kelvin.Cao
2023-12-12 17:53 ` Kelvin.Cao
2023-12-21 16:17 ` Vinod Koul
2023-07-31 15:49 ` [PATCH v6 0/1] Switchtec Switch DMA Engine Driver Logan Gunthorpe
2023-07-31 23:07 ` Kelvin.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728200327.96496-1-kelvin.cao@microchip.com \
--to=kelvin.cao@microchip.com \
--cc=George.Ge@microchip.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).