From: coolrrsh@gmail.com
To: vkoul@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Rajeshwar R Shinde <coolrrsh@gmail.com>
Subject: [PATCH] dma: dmatest: Use div64_s64
Date: Mon, 14 Aug 2023 11:52:46 +0530 [thread overview]
Message-ID: <20230814062246.4636-1-coolrrsh@gmail.com> (raw)
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
In the function do_div, the dividend is evaluated multiple times
so it can cause side effects. Therefore replace it with div64_s64.
This fixes warning such as:
drivers/dma/dmatest.c:496:1-7:
WARNING: do_div() does a 64-by-32 division,
please consider using div64_s64 instead.
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
---
drivers/dma/dmatest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ffe621695e47..07042f239db8 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -9,6 +9,7 @@
#include <linux/err.h>
#include <linux/delay.h>
+#include <linux/math64.h>
#include <linux/dma-mapping.h>
#include <linux/dmaengine.h>
#include <linux/freezer.h>
@@ -493,7 +494,7 @@ static unsigned long long dmatest_persec(s64 runtime, unsigned int val)
per_sec *= val;
per_sec = INT_TO_FIXPT(per_sec);
- do_div(per_sec, runtime);
+ per_sec=div64_s64(per_sec, runtime);
return per_sec;
}
--
2.25.1
next reply other threads:[~2023-08-14 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 6:22 coolrrsh [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 6:04 [PATCH] dma: dmatest: Use div64_s64 coolrrsh
2023-08-16 15:16 ` Greg KH
2023-08-16 18:38 ` Randy Dunlap
2023-08-17 11:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814062246.4636-1-coolrrsh@gmail.com \
--to=coolrrsh@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox