From: Simon Horman <horms@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
MD Danish Anwar <danishanwar@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
dmaengine@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] dmaengine: ti: k3-udma-glue: fix k3_udma_glue_tx_get_irq() error checking
Date: Fri, 15 Sep 2023 08:33:24 +0200 [thread overview]
Message-ID: <20230915063324.GC758782@kernel.org> (raw)
In-Reply-To: <5b29881f-a11a-4230-a044-a60871d3d38c@kili.mountain>
On Wed, Sep 13, 2023 at 02:05:31PM +0300, Dan Carpenter wrote:
> The problem is that xudma_pktdma_tflow_get_irq() returns zero on error
> and k3_ringacc_get_ring_irq_num() returns negatives. This complicates
> the error handling. Change it to always return negative errors.
>
> Both callers have other bugs as well. The am65_cpsw_nuss_init_tx_chns()
> function doesn't preserve the error code but instead returns success.
> In prueth_init_tx_chns() there is a signedness bug since "tx_chn->irq"
> is unsigned so negative errors are not handled correctly.
Hi Dan,
I understand that the problems are related, but there are several of them.
Could they be handled in separate patches (applied in a specific order) ?
I suspect this would aid backporting, and, moreover, I think it is nice
to try to work on a one-fix-per-patch basis.
The above notwithstanding, I do agree with the correctness of your changes.
> Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
> Fixes: 5b65781d06ea ("dmaengine: ti: k3-udma-glue: Add support for K3 PKTDMA")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> The k3_udma_glue_tx_get_irq() function is in dmaengine, but this bug
> affects networking so I think the fix should go through networking.
...
next prev parent reply other threads:[~2023-09-15 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:05 [PATCH net] dmaengine: ti: k3-udma-glue: fix k3_udma_glue_tx_get_irq() error checking Dan Carpenter
2023-09-15 6:33 ` Simon Horman [this message]
2023-09-15 6:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915063324.GC758782@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.ujfalusi@gmail.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox