From: "Köry Maincent" <kory.maincent@bootlin.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Cai Huoqing <cai.huoqing@linux.dev>,
Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes
Date: Wed, 11 Oct 2023 09:23:50 +0200 [thread overview]
Message-ID: <20231011092350.18049672@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20231010145906.GL4884@thinkpad>
On Tue, 10 Oct 2023 20:29:06 +0530
Manivannan Sadhasivam <mani@kernel.org> wrote:
> On Mon, Oct 02, 2023 at 03:17:46PM +0200, Köry Maincent wrote:
> > From: Kory Maincent <kory.maincent@bootlin.com>
> >
> > Fix "HDMA_V0_REMOTEL_STOP_INT_EN" typo error.
> > Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> > bit is already set in the same line.
> >
>
> You should split this into two patches. First one is a typo and is harmless,
> but the second is a _bug_.
Thanks for your review.
Ok I will do so.
Serge if it is ok for you I will keep your reviewed by on the two separate
patches.
next prev parent reply other threads:[~2023-10-11 7:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 13:17 [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP in remote setup Köry Maincent
2023-10-02 13:17 ` [PATCH v2 1/5] dmaengine: dw-edma: Fix the ch_count hdma callback Köry Maincent
2023-10-03 11:23 ` Serge Semin
2023-10-10 14:56 ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes Köry Maincent
2023-10-10 14:59 ` Manivannan Sadhasivam
2023-10-11 7:23 ` Köry Maincent [this message]
2023-10-11 10:38 ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 3/5] dmaengine: dw-edma: Add HDMA remote interrupt configuration Köry Maincent
2023-10-10 15:00 ` Manivannan Sadhasivam
2023-10-02 13:17 ` [PATCH v2 4/5] dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup Köry Maincent
2023-10-03 11:48 ` Serge Semin
2023-10-03 12:15 ` Köry Maincent
2023-10-03 15:20 ` Serge Semin
2023-10-03 15:34 ` Köry Maincent
2023-10-03 15:57 ` Serge Semin
2023-10-02 13:17 ` [PATCH v2 5/5] dmaengine: dw-edma: eDMA: " Köry Maincent
2023-10-03 11:59 ` Serge Semin
2023-10-03 12:17 ` Köry Maincent
2023-10-04 7:21 ` [PATCH v2 0/5] Fix support of dw-edma HDMA NATIVE IP " Vinod Koul
2023-10-04 8:04 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011092350.18049672@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=cai.huoqing@linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox