From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93094495C8 for ; Tue, 21 Nov 2023 12:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LxWBqy9U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5549C433C9; Tue, 21 Nov 2023 12:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700568522; bh=xY/S+drvjUTqo2Fu2FpUAKYEb7XcjqGXCgM5ZYigqpI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LxWBqy9UnCrGoq3oBdWsp9PGMjwX7o7lQB4D4cAFspVDDEzdm5Rav9/N168AUm8N0 hdKRHRpQYw0ljwk0KcHOd0jUhTEvIWFPeiArFDdoPU4IrA7U3QYb1z+/dgj69VQoAc mG7s8o2GEMP1PuGAGPoIsNLRW/lXPLSiVCk7M3SObX6IbuZWKRvcbaWXLgaZURsFNN WO4/JmldKDx1guTwRg7s/FXMzvtaWylSESJLort26n6tx2isMCmupoje6lspivqtd3 P1NcXQlLBETlPYSWfEWOUTAxy3dnv3DogJjX3F2c14emfUTjhjJrBzzT+hq4WFL2km i5NBtxDZafi1g== Date: Tue, 21 Nov 2023 17:38:28 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Kory Maincent , Gustavo Pimentel , Vinod Koul , Cai Huoqing , Thomas Petazzoni , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina Subject: Re: [PATCH v6 0/6] Fix support of dw-edma HDMA NATIVE IP in remote setup Message-ID: <20231121120828.GC3315@thinkpad> References: <20231117-b4-feature_hdma_mainline-v6-0-ebf7aa0e40d7@bootlin.com> <20231121062629.GA3315@thinkpad> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 21, 2023 at 01:55:22PM +0300, Serge Semin wrote: > Hi Mani > > On Tue, Nov 21, 2023 at 11:56:29AM +0530, Manivannan Sadhasivam wrote: > > On Fri, Nov 17, 2023 at 11:03:48AM +0100, Kory Maincent wrote: > > > This patch series fix the support of dw-edma HDMA NATIVE IP. > > > I can only test it in remote HDMA IP setup with single dma transfer, but > > > with these fixes it works properly. > > > > > > Few fixes has also been added for eDMA version. Similarly to HDMA I have > > > tested only eDMA in remote setup. > > > > > > > Just out of curiosity, can you share how you are setting EDMA_MF_HDMA_NATIVE? > > This topic has already been concerned on v1 (in another context > though): > https://lore.kernel.org/dmaengine/20230621151948.36125997@kmaincent-XPS-13-7390/ > > Here is the repo with the out-of-tree driver Kory said he was using > together with the kernel's version of the DW eDMA/hDMA driver: > https://github.com/Brainchip-Inc/akida_dw_edma > Thanks Sergey, I missed it! But looks like we are not focusing on the HDMA integration in designware-ep.c. Have you/anyone thought about it? Was it discussed previously that I missed? HDMA is used in one of the recent Qcom SoCs (SA8775) that Qcom folks are bringing up and I'd like to have a common solution like we have for eDMA. - Mani > -Serge(y) > > > > > - Mani > > > > > Changes in v2: > > > - Update comments and fix typos. > > > - Removed patches that tackle hypothetical bug and then were not pertinent. > > > - Add the similar HDMA race condition in remote setup fix to eDMA IP driver. > > > > > > Changes in v3: > > > - Fix comment style. > > > - Split a patch in two to differ bug fix and simple harmless typo. > > > > > > Changes in v4: > > > - Update patch git commit message. > > > - Link to v3: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v3-0-24ee0c979c6f@bootlin.com > > > > > > Changes in v5: > > > - No change > > > - Rebase to mainline 6.7-rc1 > > > - Link to v4: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v4-0-43d417b93138@bootlin.com > > > > > > Changes in v6: > > > - Fix several commit messages and comments. > > > - Link to v5: https://lore.kernel.org/r/20231114-b4-feature_hdma_mainline-v5-0-7bc86d83c6f7@bootlin.com > > > > > > Signed-off-by: Kory Maincent > > > --- > > > Kory Maincent (6): > > > dmaengine: dw-edma: Fix the ch_count hdma callback > > > dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA > > > dmaengine: dw-edma: HDMA_V0_REMOTEL_STOP_INT_EN typo fix > > > dmaengine: dw-edma: Add HDMA remote interrupt configuration > > > dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup > > > dmaengine: dw-edma: eDMA: Add sync read before starting the DMA transfer in remote setup > > > > > > drivers/dma/dw-edma/dw-edma-v0-core.c | 17 +++++++++++++++ > > > drivers/dma/dw-edma/dw-hdma-v0-core.c | 39 +++++++++++++++++++++++------------ > > > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 2 +- > > > 3 files changed, 44 insertions(+), 14 deletions(-) > > > --- > > > base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86 > > > change-id: 20231011-b4-feature_hdma_mainline-b6c57f8e3b5d > > > > > > Best regards, > > > -- > > > Köry Maincent, Bootlin > > > Embedded Linux and kernel engineering > > > https://bootlin.com > > > > > > > -- > > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம்