From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C2270022 for ; Wed, 28 Feb 2024 21:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709156000; cv=none; b=l4keC2NR6jNknWpNjq6oft8fX9zW7xIX3kkR0wgcc5juk5rLS1tmMrS2F+BNhq4G64xcOIuMLhLrk6RDiyegCNHfUCZFbE23K4xwJQRhcZ2mxGVuQZU5o8FGeENIcXeVJ5pBvPsIM8CvT0T4G8FrAKdiqxEVu3ozx+7UKLFQiu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709156000; c=relaxed/simple; bh=2QplW/PSL+l5wBlz2Fhb2MD7icGVtnf5yghrdyR7zlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MIv4laqUNa86okflanleofISYaK4iWCLXLcYQdOZjdgiz0saKuwoCYxtLFSZU2jmvdNFauIfr+yHX2dRo1KJLGUJ1yBq4bGtjw73fWPguSp1iJhU8zZQdV+9VBGZFvuWNo3vBVvgqtQplcyGCYQSwYzpZrA/3OPbZy8vXaVIurE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aBN6sDQb; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aBN6sDQb" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d944e8f367so2158545ad.0 for ; Wed, 28 Feb 2024 13:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709155997; x=1709760797; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XLd8h0kEPBZWXG99LoXPX1j7y1LhX/a2aDKq9S3uX68=; b=aBN6sDQbxrowODDrLK+SjX+fBVboj16jTtc0JmnAsYlX+IxsJR//Q78Ef229q7BVeH k1loVZK1lowplOUnadJZy6JVfXerQXD8WmyZTW9TvRQjvfhk9aXLvNV/TdU3BT+CZ6AJ AA8I7rfTB85C3iJawTE0geey0WYKINkco6uXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709155997; x=1709760797; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XLd8h0kEPBZWXG99LoXPX1j7y1LhX/a2aDKq9S3uX68=; b=NsT1u0GEJk3eVZCilTTSWVhIaZKwLM3lx0J+UH4BqYdGitwh/tY+UijSJNVjUGh5w7 Anlip4yaghf9Zkv4L3Ip3kE+WnZXi+XLIscrm3meiuXAq9gbmEX6LHlzJh3G0VQuR5vB efH6aWJTproIuLYpDCh56+1evBkbNWF097raUx9gQS50/mMwxQqJV679pZmB8/CEPBjX ibfxYYQqc/VCg7GqkKMe9Ahb2+KP1gwSRGeq1u4ast+NBTBD3XdOlQZjGDNsLpiXp8TT 8yn2KDsWCd0QvW5wYyuM+QOS7PW1NalFA09F6sC826kvvAdSJ3trSb79D5R44518jjlm U1Vg== X-Forwarded-Encrypted: i=1; AJvYcCU5KtO5CY/FczB9+ug73r2BNU3vl9UroV7f5/Yx0b0Vgvyr3g4HkAbQGyWN1EU+Z+ejeqvrxuBHRVQsBfRpHEEqUMNIsgvF8WCz X-Gm-Message-State: AOJu0YyTYVY3CqmuqfemOWRgozhHvxgUIJmENXeqWuOTDF2YieEDAOfM GFp7AxapBpH2IefWwZaeG8K1MDvq2wpGJfCOHMHtgRRuy2txmpGrAuvuDbMixg== X-Google-Smtp-Source: AGHT+IGO5QT2ql8Rf0ElQjy3mY7mI7ajEF2Z3zSl9mRYp9jbKdiPIbR1SfabYEntk3bTWsEUAJJ/WQ== X-Received: by 2002:a17:902:ce02:b0:1d9:f83e:3a54 with SMTP id k2-20020a170902ce0200b001d9f83e3a54mr192671plg.64.1709155996838; Wed, 28 Feb 2024 13:33:16 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c2-20020a170902848200b001dca997b3e3sm3729404plo.65.2024.02.28.13.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 13:33:15 -0800 (PST) Date: Wed, 28 Feb 2024 13:33:15 -0800 From: Kees Cook To: Andy Shevchenko Cc: Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow() Message-ID: <202402281332.9B2F13570@keescook> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote: > The check_shl_overflow() uses u64 type that is defined in types.h. > Instead of including that header, just switch to use POD type > directly. > > Signed-off-by: Andy Shevchenko Acked-by: Kees Cook -- Kees Cook