From: Conor Dooley <conor@kernel.org>
To: Tan Chun Hau <chunhau.tan@starfivetech.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
Jee Heng Sia <jeeheng.sia@starfivetech.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
Date: Tue, 26 Mar 2024 18:32:39 +0000 [thread overview]
Message-ID: <20240326-maternity-alive-6cb8f6b2e037@spud> (raw)
In-Reply-To: <20240326095457.201572-2-chunhau.tan@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.
Your commit message should explain what makes this incompatible with
existing devices. That inforatiion does appear to be in the driver
patch, but should also be here. Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 363cf8bd150d..525f5f3932f5 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -21,6 +21,7 @@ properties:
> - snps,axi-dma-1.01a
> - intel,kmb-axi-dma
> - starfive,jh7110-axi-dma
> + - starfive,jh8100-axi-dma
>
> reg:
> minItems: 1
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-03-26 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:54 [PATCH 0/2] Add JH8100 support for snps,dw-axi-dmac Tan Chun Hau
2024-03-26 9:54 ` [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support Tan Chun Hau
2024-03-26 18:32 ` Conor Dooley [this message]
2024-03-27 2:50 ` ChunHau Tan
2024-03-26 9:54 ` [PATCH 2/2] dmaengine: dw-axi-dmac: Add support for StarFive JH8100 DMA Tan Chun Hau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326-maternity-alive-6cb8f6b2e037@spud \
--to=conor@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=chunhau.tan@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jeeheng.sia@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox