Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

On Wed, Mar 27, 2024 at 08:24:01AM +0000, ChunHau Tan wrote:
> 
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Sent: Wednesday, 27 March, 2024 3:50 PM
> > To: ChunHau Tan <chunhau.tan@starfivetech.com>; Eugeniy Paltsev
> > <Eugeniy.Paltsev@synopsys.com>; Vinod Koul <vkoul@kernel.org>; Rob Herring
> > <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> > Conor Dooley <conor+dt@kernel.org>
> > Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> > <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> > support
> > 
> > On 27/03/2024 03:51, Tan Chun Hau wrote:
> > > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > > controller.
> > >
> > > Both JH8100 and JH7110 require reset operation in device probe.
> > > However, JH8100 doesn't need to apply different configuration on
> > > CH_CFG registers.
> > 
> > This is a friendly reminder during the review process.
> > 
> > It looks like you received a tag and forgot to add it.
> > 
> > If you do not know the process, here is a short explanation:
> > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions,
> > under or above your Signed-off-by tag. Tag is "received", when provided in a
> > message replied to you on the mailing list. Tools like b4 can help here. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for tags received on the version they apply.
> > 
> > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitt
> > ing-patches.rst#L577
> > 
> > If a tag was not added on purpose, please state why and what changed.
> 
> Hi Krzysztof, thank you very much for the feedback,
> Sorry I overlooked it.
> Do you prefer I resend V2 patch or send a V3 patch to include the Acked-by ?

I resent the tag, you do not need to do anything.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]