From: Christoph Hellwig <hch@lst.de>
To: Lizhi Hou <lizhi.hou@amd.com>
Cc: vkol@kernel.org, hch@lst.de, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, nishads@amd.com
Subject: Re: [PATCH 1/1] dmaengine: amd: qdma: Remove using the private get and set dma_ops APIs
Date: Wed, 18 Sep 2024 14:13:02 +0200 [thread overview]
Message-ID: <20240918121302.GB21062@lst.de> (raw)
In-Reply-To: <20240917161740.2111871-1-lizhi.hou@amd.com>
On Tue, Sep 17, 2024 at 09:17:40AM -0700, Lizhi Hou wrote:
> The get_dma_ops and set_dma_ops APIs were never for driver to use. Remove
> these calls from QDMA driver. Instead, pass the DMA device pointer from the
> qdma_platdata structure.
Btw, this file should also drop the include of <linux/dma-map-ops.h>,
which is clearly marked as not for driver use.
next prev parent reply other threads:[~2024-09-18 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 16:17 [PATCH 1/1] dmaengine: amd: qdma: Remove using the private get and set dma_ops APIs Lizhi Hou
2024-09-18 5:22 ` Christoph Hellwig
2024-09-18 12:13 ` Christoph Hellwig [this message]
2024-09-18 17:37 ` Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918121302.GB21062@lst.de \
--to=hch@lst.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=nishads@amd.com \
--cc=vkol@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox