From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: ChunyouTang <tangchunyou@163.com>
Cc: fancer.lancer@gmail.com, vkoul@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma/dw-edma: chip regs base should add the offset
Date: Tue, 15 Oct 2024 11:06:08 +0530 [thread overview]
Message-ID: <20241015053608.h2avloxfak5yagyd@thinkpad> (raw)
In-Reply-To: <20241014134832.4505-1-tangchunyou@163.com>
On Mon, Oct 14, 2024 at 09:48:32PM +0800, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@163.com>
>
> fix the regs base with offset.
>
Initially I thought that this patch is a spam, but it is not. It is indeed
fixing a real bug in the driver. But the subject and description made it look
like a spam. Please follow the process defined in:
Documentation/process/5.Posting.rst to send the patches.
Essentially you need to properly describe what the patch does and how it impacts
the driver etc... Then there needs to be a valid 'Fixes' tag and stable list
should be CCed to backport to stable kernels.
- Mani
> Signed-off-by: tangchunyou <tangchunyou@163.com>
> ---
> drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 1c6043751dc9..2918b64708f9 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
> if (!chip->reg_base)
> return -ENOMEM;
>
> + chip->reg_base += vsec_data.rg.off;
> +
> for (i = 0; i < chip->ll_wr_cnt; i++) {
> struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
> struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-10-15 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 13:48 [PATCH] dma/dw-edma: chip regs base should add the offset ChunyouTang
2024-10-15 5:36 ` Manivannan Sadhasivam [this message]
2024-10-15 10:45 ` 唐春有
2024-10-16 4:56 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2024-10-16 8:17 ChunyouTang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015053608.h2avloxfak5yagyd@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tangchunyou@163.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox