From: "Ivan T . Ivanov" <iivanov@suse.de>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Russell King <linux@armlinux.org.uk>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Vinod Koul <vkoul@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Minas Harutyunyan <hminas@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lukas Wunner <lukas@wunner.de>,
Peter Robinson <pbrobinson@gmail.com>,
linux-arm-kernel@lists.infradead.org,
kernel-list@raspberrypi.com,
bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH V5 1/9] Revert "usb: dwc2: Skip clock gating on Broadcom SoCs"
Date: Tue, 29 Oct 2024 11:44:45 +0200 [thread overview]
Message-ID: <20241029094445.hsporitxkv2q45c5@localhost.localdomain> (raw)
In-Reply-To: <20241025103621.4780-2-wahrenst@gmx.net>
Hi Stefan,
On 10-25 12:36, Stefan Wahren wrote:
>
> The commit d483f034f032 ("usb: dwc2: Skip clock gating on Broadcom SoCs")
> introduced a regression on Raspberry Pi 3 B Plus, which prevents
> enumeration of the onboard Microchip LAN7800 in case no external USB device
> is connected during boot.
>
> Fixes: d483f034f032 ("usb: dwc2: Skip clock gating on Broadcom SoCs")
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
> drivers/usb/dwc2/params.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 68226defdc60..4d73fae80b12 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -23,7 +23,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
> p->max_transfer_size = 65535;
> p->max_packet_count = 511;
> p->ahbcfg = 0x10;
> - p->no_clock_gating = true;
> }
>
Thanks, this makes RPi3 Ethernet operational again.
Tested-by: Ivan T. Ivanov <iivanov@suse.de>
Regards.
next prev parent reply other threads:[~2024-10-29 9:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 10:36 [PATCH V5 0/9] ARM: bcm2835: Implement initial S2Idle for Raspberry Pi Stefan Wahren
2024-10-25 10:36 ` [PATCH V5 1/9] Revert "usb: dwc2: Skip clock gating on Broadcom SoCs" Stefan Wahren
2024-10-29 9:44 ` Ivan T . Ivanov [this message]
2024-10-25 10:36 ` [PATCH V5 2/9] dmaengine: bcm2835-dma: add suspend/resume pm support Stefan Wahren
2024-11-09 17:37 ` Stefan Wahren
2024-12-02 16:52 ` Vinod Koul
2024-12-02 18:51 ` Stefan Wahren
2024-12-04 12:27 ` Vinod Koul
2024-10-25 10:36 ` [PATCH V5 3/9] mmc: bcm2835: Fix type of current clock speed Stefan Wahren
2024-10-28 11:43 ` Ulf Hansson
2024-10-25 10:36 ` [PATCH V5 4/9] mmc: bcm2835: Introduce proper clock handling Stefan Wahren
2024-10-28 11:43 ` Ulf Hansson
2024-10-25 10:36 ` [PATCH V5 5/9] mmc: bcm2835: add suspend/resume pm support Stefan Wahren
2024-10-28 10:56 ` Ulf Hansson
2024-10-25 10:36 ` [PATCH V5 6/9] usb: dwc2: gadget: Introduce register restore flags Stefan Wahren
2024-10-25 10:36 ` [PATCH V5 7/9] usb: dwc2: Refactor backup/restore of registers Stefan Wahren
2024-10-25 10:36 ` [PATCH V5 8/9] usb: dwc2: Implement recovery after PM domain off Stefan Wahren
2024-10-25 10:36 ` [PATCH V5 9/9] ARM: bcm2835_defconfig: Enable SUSPEND Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029094445.hsporitxkv2q45c5@localhost.localdomain \
--to=iivanov@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dmaengine@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=pbrobinson@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox