From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6435670807; Tue, 11 Feb 2025 11:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739272865; cv=none; b=iWNzxTFTegwmEh5yyixVK0TeMe/KzP7PS4UpakeZ6ytw7kc3JMXaXWrFGVF5wHHqvhQ5fR7eg7zcvNCfjQ5O1LUqj6YjbuF+myC0frtv4XyBq5FzJy2xINA+RyH5cCgM3HqryEi40osTKIIi+CXaxttK0OHxzITD8PJSKtEAqMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739272865; c=relaxed/simple; bh=uoP1nCCvDBGx8Z7jqAGdTm1hPsk3dkyFnV2/E09V82I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r6xCWcSlXckiZTLw8VYOZmjbJRmiwVxVXC+sOiKikeOmWYTK3MqaL54zCi33t3qk/ODp9DT0qYuPbiynopixgatapuGX/XZzh7Jfgfmiz/jjl/luFQQ+jlICC8DorXM9s9My95WPVP3BXUpYQWRP8dogymdjWW1dfbG/aeFMAa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=hMrujhFc; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="hMrujhFc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1739272861; bh=uoP1nCCvDBGx8Z7jqAGdTm1hPsk3dkyFnV2/E09V82I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hMrujhFcOZq/4f66dL7dk+b6M2gxuegP3AwaTO8f1n9aKVEgZtlMNnY4Bhx/ejzMo pGydGWXFHnA9dpurrQF5alPZvAbxpAYPoU8StnnR1TnOtC2kRfP0P0HWRkql/TO0D/ AO/IjMCit3Ob3tK2swaYdx2cFbxh+ddFXuYpgwwwBd/TLPrl0etaxbXsqx1rZMR+4S qW2a+K82BrOMXpC4modD0gLaLNGAhu1FPLTJcT5saZWCgOb/A7j6w2vZofUsFr1CLV 5FdHFaAPaZrnZNYD5X11VJbi2Nzamdxrpz3mFC12cUu6rMtJJ8VrGRjTBAVvRBuD+w 85thIsVMvH2Jw== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 77FD117E0657; Tue, 11 Feb 2025 12:21:00 +0100 (CET) Date: Tue, 11 Feb 2025 12:20:52 +0100 From: Boris Brezillon To: Florent Tomasin Cc: Vinod Koul , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T . J . Mercier" , Christian =?UTF-8?B?S8O2bmln?= , Matthias Brugger , AngeloGioacchino Del Regno , Yong Wu , , , , , , , , , , Akash Goel Subject: Re: [RFC PATCH 4/5] drm/panthor: Add support for protected memory allocation in panthor Message-ID: <20250211122052.3f550650@collabora.com> In-Reply-To: <20250211120448.3e89e75f@collabora.com> References: <821252c96ab2ab3e2d8ef211a09f8b171719baaa.1738228114.git.florent.tomasin@arm.com> <20250211120448.3e89e75f@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 11 Feb 2025 12:04:48 +0100 Boris Brezillon wrote: > > --- a/drivers/gpu/drm/panthor/panthor_gem.c > > +++ b/drivers/gpu/drm/panthor/panthor_gem.c > > @@ -9,10 +9,14 @@ > > > > #include > > > > +#include > > + > > #include "panthor_device.h" > > #include "panthor_gem.h" > > #include "panthor_mmu.h" > > > > +MODULE_IMPORT_NS(DMA_BUF); > > Uh, that's ugly. If the consensus is to let panthor allocate > its protected buffers from a heap, let's just add a dependency on > DMABUF_HEAPS instead. My bad, that one is required for dma_buf_put(). Should be MODULE_IMPORT_NS("DMA_BUF"); though.