From: Eder Zulian <ezulian@redhat.com>
To: Basavaraj.Natikar@amd.com, vkoul@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Eder Zulian <ezulian@redhat.com>
Subject: [PATCH] dmaengine: ptdma: Remove unused pointer dma_cmd_cache
Date: Wed, 9 Apr 2025 13:40:19 +0200 [thread overview]
Message-ID: <20250409114019.42026-1-ezulian@redhat.com> (raw)
The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
resource") but it was never used.
Signed-off-by: Eder Zulian <ezulian@redhat.com>
---
drivers/dma/amd/ptdma/ptdma-dmaengine.c | 3 ---
drivers/dma/amd/ptdma/ptdma.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
index 715ac3ae067b..3f7f6da05142 100644
--- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
@@ -656,8 +656,6 @@ int pt_dmaengine_register(struct pt_device *pt)
kmem_cache_destroy(pt->dma_desc_cache);
err_cache:
- kmem_cache_destroy(pt->dma_cmd_cache);
-
return ret;
}
EXPORT_SYMBOL_GPL(pt_dmaengine_register);
@@ -669,5 +667,4 @@ void pt_dmaengine_unregister(struct pt_device *pt)
dma_async_device_unregister(dma_dev);
kmem_cache_destroy(pt->dma_desc_cache);
- kmem_cache_destroy(pt->dma_cmd_cache);
}
diff --git a/drivers/dma/amd/ptdma/ptdma.h b/drivers/dma/amd/ptdma/ptdma.h
index 0a7939105e51..ef3f55632107 100644
--- a/drivers/dma/amd/ptdma/ptdma.h
+++ b/drivers/dma/amd/ptdma/ptdma.h
@@ -254,7 +254,6 @@ struct pt_device {
/* Support for the DMA Engine capabilities */
struct dma_device dma_dev;
struct pt_dma_chan *pt_dma_chan;
- struct kmem_cache *dma_cmd_cache;
struct kmem_cache *dma_desc_cache;
wait_queue_head_t lsb_queue;
--
2.49.0
next reply other threads:[~2025-04-09 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 11:40 Eder Zulian [this message]
2025-04-14 22:58 ` [PATCH] dmaengine: ptdma: Remove unused pointer dma_cmd_cache Nathan Lynch
2025-04-15 12:23 ` Eder Zulian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409114019.42026-1-ezulian@redhat.com \
--to=ezulian@redhat.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox