[PATCH 0/5] dmaengine: Minor fixes and cleanups

[PATCH 0/5] dmaengine: Minor fixes and cleanups

[Krzysztof Kozlowski]

Just few cleanups and fixes.  Funny thing that the reported cast error
I fix the second time.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (5):
      dmaengine: dw-edma: Drop unused dchan2dev() and chan2dev()
      dmaengine: fsl-dpaa2-qdma: Drop unused mc_enc()
      dmaengine: qcom: gpi: Drop unused gpi_write_reg_field()
      dmaengine: fsl-qdma: Add missing fsl_qdma_format kerneldoc
      dmaengine: mmp: Fix again Wvoid-pointer-to-enum-cast warning

 drivers/dma/dw-edma/dw-edma-core.c  | 12 ------------
 drivers/dma/fsl-dpaa2-qdma/dpdmai.c |  5 -----
 drivers/dma/fsl-qdma.c              |  3 +++
 drivers/dma/mmp_tdma.c              |  2 +-
 drivers/dma/qcom/gpi.c              | 11 -----------
 5 files changed, 4 insertions(+), 29 deletions(-)
---
base-commit: 781af674a40df73239e8907d5862fd6fbcf01a9a
change-id: 20250525-dma-fixes-0b57fcec5f20

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[PATCH 1/5] dmaengine: dw-edma: Drop unused dchan2dev() and chan2dev()

[Krzysztof Kozlowski]

Static functions dchan2dev() and chan2dev() are not used, W=1 build:

  dw-edma-core.c:27:16: error: unused function 'dchan2dev' [-Werror,-Wunused-function]
  dw-edma-core.c:33:16: error: unused function 'chan2dev' [-Werror,-Wunused-function]

Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/dw-edma/dw-edma-core.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index c2b88cc99e5d2d7c1ea4489d4a8f561ee5f0785d..b43255f914f3395f5d0be438151d9dd0d52764ff 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -23,18 +23,6 @@
 #include "../dmaengine.h"
 #include "../virt-dma.h"
 
-static inline
-struct device *dchan2dev(struct dma_chan *dchan)
-{
-	return &dchan->dev->device;
-}
-
-static inline
-struct device *chan2dev(struct dw_edma_chan *chan)
-{
-	return &chan->vc.chan.dev->device;
-}
-
 static inline
 struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
 {

-- 
2.45.2

[PATCH 2/5] dmaengine: fsl-dpaa2-qdma: Drop unused mc_enc()

[Krzysztof Kozlowski]

Static function mc_enc() is not used, W=1 build:

  dpdmai.c:51:19: error: unused function 'mc_enc' [-Werror,-Wunused-function]

Fixes: 26a4d2aedac2 ("dmaengine: fsl-dpaa2-qdma: Remove unused function dpdmai_create()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/fsl-dpaa2-qdma/dpdmai.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/dma/fsl-dpaa2-qdma/dpdmai.c b/drivers/dma/fsl-dpaa2-qdma/dpdmai.c
index b4323d243d6de8a1ec77436ce45579914230b9b6..4be81db24a1945fde62d9d7a00b9809a65271101 100644
--- a/drivers/dma/fsl-dpaa2-qdma/dpdmai.c
+++ b/drivers/dma/fsl-dpaa2-qdma/dpdmai.c
@@ -48,11 +48,6 @@ struct dpdmai_cmd_destroy {
 	__le32 dpdmai_id;
 } __packed;
 
-static inline u64 mc_enc(int lsoffset, int width, u64 val)
-{
-	return (val & MAKE_UMASK64(width)) << lsoffset;
-}
-
 /**
  * dpdmai_open() - Open a control session for the specified object
  * @mc_io:	Pointer to MC portal's I/O object

-- 
2.45.2

[PATCH 3/5] dmaengine: qcom: gpi: Drop unused gpi_write_reg_field()

[Krzysztof Kozlowski]

Static function gpi_write_reg_field() is not used, W=1 build:

  gpi.c:573:20: error: unused function 'gpi_write_reg_field' [-Werror,-Wunused-function]

Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/qcom/gpi.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index b1f0001cc99c7066b6d08f53d9381d4fd22588ca..8e87738086b25ac37edbdcd5e237447f3e832e8e 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -569,17 +569,6 @@ static inline void gpi_write_reg(struct gpii *gpii, void __iomem *addr, u32 val)
 	writel_relaxed(val, addr);
 }
 
-/* gpi_write_reg_field - write to specific bit field */
-static inline void gpi_write_reg_field(struct gpii *gpii, void __iomem *addr,
-				       u32 mask, u32 shift, u32 val)
-{
-	u32 tmp = gpi_read_reg(gpii, addr);
-
-	tmp &= ~mask;
-	val = tmp | ((val << shift) & mask);
-	gpi_write_reg(gpii, addr, val);
-}
-
 static __always_inline void
 gpi_update_reg(struct gpii *gpii, u32 offset, u32 mask, u32 val)
 {

-- 
2.45.2

[PATCH 4/5] dmaengine: fsl-qdma: Add missing fsl_qdma_format kerneldoc

[Krzysztof Kozlowski]

Document '__reserved2' and 'cmd' fields of 'struct fsl_qdma_format' to
fix W=1 warnings:

  fsl-qdma.c:169 struct member '__reserved2' not described in 'fsl_qdma_format'
  fsl-qdma.c:169 struct member 'cmd' not described in 'fsl_qdma_format'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/fsl-qdma.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index 823f5c6bc2e1a5bc5e30ea7175bff31e53ff8744..21e13f1207cbe6e82a45c828b93edcadf88b52d1 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -148,6 +148,9 @@
  * @__reserved1:	    Reserved field.
  * @cfg8b_w1:		    Compound descriptor command queue origin produced
  *			    by qDMA and dynamic debug field.
+ * @__reserved2:	    Reserved field.
+ * @cmd:		    Command for QDMA (see FSL_QDMA_CMD_RWTTYPE and
+ *			     others).
  * @data:		    Pointer to the memory 40-bit address, describes DMA
  *			    source information and DMA destination information.
  */

-- 
2.45.2

[PATCH 5/5] dmaengine: mmp: Fix again Wvoid-pointer-to-enum-cast warning

[Krzysztof Kozlowski]

This was fixed and re-introduced.  'type' is an enum, thus cast of
pointer on 64-bit compile test with W=1 causes:

  mmp_tdma.c:644:9: error: cast to smaller integer type 'enum mmp_tdma_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

Fixes: a67ba97dfb30 ("dmaengine: Use device_get_match_data()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/mmp_tdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index c8dc504510f1e325017ba4fa5e7aa72b019e3be4..b7fb843c67a6f247395296fc726f7b6cab7d223f 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -641,7 +641,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
 	int chan_num = TDMA_CHANNEL_NUM;
 	struct gen_pool *pool = NULL;
 
-	type = (enum mmp_tdma_type)device_get_match_data(&pdev->dev);
+	type = (kernel_ulong_t)device_get_match_data(&pdev->dev);
 
 	/* always have couple channels */
 	tdev = devm_kzalloc(&pdev->dev, sizeof(*tdev), GFP_KERNEL);

-- 
2.45.2

Re: [PATCH 0/5] dmaengine: Minor fixes and cleanups

[Vinod Koul]

On Sun, 25 May 2025 21:26:00 +0200, Krzysztof Kozlowski wrote:
> Just few cleanups and fixes.  Funny thing that the reported cast error
> I fix the second time.
> 
> Best regards,
> Krzysztof
> 

Applied, thanks!

[1/5] dmaengine: dw-edma: Drop unused dchan2dev() and chan2dev()
      commit: 06b80ad4ffa5e614e89f04dffc44b85377c7ee24
[2/5] dmaengine: fsl-dpaa2-qdma: Drop unused mc_enc()
      commit: f0368c23caba175e07062a3f24e58a2b4ec5bb1c
[3/5] dmaengine: qcom: gpi: Drop unused gpi_write_reg_field()
      commit: 24c13df655ca1fad5fc6fa4fbacb828f4a6d4f2b
[4/5] dmaengine: fsl-qdma: Add missing fsl_qdma_format kerneldoc
      commit: 85a4ca2902c1d3b8ccea03837b10e178405192c5
[5/5] dmaengine: mmp: Fix again Wvoid-pointer-to-enum-cast warning
      commit: a0b1589b62e2fcfb112996e0f4d5593bd2edf069

Best regards,
-- 
~Vinod