From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC2922425E; Thu, 18 Sep 2025 15:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758208713; cv=none; b=pqezMrWMYN1QBq5RoPsCoOMXE2RJTuduOM+vmclmFdHW8SUe224ap6Ht1vYXcGoefISHJtT3TMWoxzNfQEGQvFYYKJLUtwHhPsaX0LLELaFMakhkfuxsjN6P32uHjv73VYji5G8YLR2wOeQbPGSQ1DOZoXZ2GHxq7Y6ptEy9IAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758208713; c=relaxed/simple; bh=T4wS9mTXcpSpv5NeMblAj4UwyO9r3doA7Bdhw2LH3VI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bBjcA+hLzwamDR8Qxz+zW+D3gPYuOxjy8ibUzhcRM6kwKBd4UesaVHrTwhZpN/EquqkCqdrUTi4AjHD8GI/Pgq2yVpLR0FqUCKj00QAF4iUIaWipgYBjbtudckA3B5+HcoTXf1SfTN2YTGYjVy1sB266xn0B6jxwR3/0BLgcS50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uLi4AGnf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uLi4AGnf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECAE5C4CEE7; Thu, 18 Sep 2025 15:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758208712; bh=T4wS9mTXcpSpv5NeMblAj4UwyO9r3doA7Bdhw2LH3VI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uLi4AGnfRF6V6De0JAQgyez9xlUDmOFx461zVUm3XCG3sP4T0+DSxdMQyyFkuOUhV +Vh0+IHpwVsE1AZMdCz4UjHMuDlwhMrk39tlWhDcGgoEsf0H6LULv5ssc1b5PCpbhd JdIa4NK88xzdm/0CBrNg88tIE/Fx13gh/UUhVDeR2zvkFOqfwIosu0udNELsXGdBkl Js0qFWwQZgoA63M3jyhl2eCC8j64ckbBPtWR2RrV6aeDGgTIOkwrsNNEzkg2vc6zCf TfonVsjS25GolhGQGXBUZ0rgcw0cK/3wgOdylL6W6s1718xsH2XOddKjhMSuq6sr/2 Gdq9xsJAzr/NA== Date: Thu, 18 Sep 2025 16:18:25 +0100 From: Conor Dooley To: Dang Huynh Cc: Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Alexandre Belloni , Michael Turquette , Stephen Boyd , Philipp Zabel , Sebastian Reichel , Vinod Koul , Kees Cook , "Gustavo A. R. Silva" , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, dmaengine@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 05/25] dt-bindings: rtc: Add RDA Micro RDA8810PL RTC Message-ID: <20250918-unharmed-bloating-8b573513fce6@spud> References: <20250917-rda8810pl-drivers-v1-0-74866def1fe3@mainlining.org> <20250917-rda8810pl-drivers-v1-5-74866def1fe3@mainlining.org> <20250917-contort-sassy-df07fd7515a0@spud> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qnPPSzmWE/KqIUbp" Content-Disposition: inline In-Reply-To: --qnPPSzmWE/KqIUbp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 18, 2025 at 11:11:10AM +0700, Dang Huynh wrote: > On 2025-09-18 03:46, Conor Dooley wrote: > > On Wed, Sep 17, 2025 at 03:07:22AM +0700, Dang Huynh wrote: > > > Add documentation describing the RTC found in RDA8810PL SoC. > > >=20 > > > Signed-off-by: Dang Huynh > > > --- > > > .../devicetree/bindings/rtc/rda,8810pl-rtc.yaml | 30 > > > ++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > >=20 > > > diff --git > > > a/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml > > > b/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml > > > new file mode 100644 > > > index 0000000000000000000000000000000000000000..3ceae294921cc3211cd77= 5d9b3890393196faf82 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml > > > @@ -0,0 +1,30 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/rtc/rda,8810pl-rtc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: RDA Micro RDA8810PL Real Time Clock > > > + > > > +maintainers: > > > + - Dang Huynh > > > + > > > +properties: > > > + compatible: > > > + const: rda,8810pl-rtc > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > >=20 > > Your driver implements functions that turn on an alarm irq, but there is > > none mentioned here. What's going on there? > The RTC doesn't seem to have an AP IRQ associated. I can't find any > reference to it on downstream kernel and the docs. >=20 > >=20 > > Additionally, there's no clocks property? For an onboard RTC I'd have > > expected there to be a clock sourced outside of the block. What about the clock? > >=20 > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + rtc@1a06000 { > > > + compatible =3D "rda,8810pl-rtc"; > > > + reg =3D <0x1a06000 0x1000>; > > > + }; > > >=20 > > > -- > > > 2.51.0 --qnPPSzmWE/KqIUbp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaMwiwQAKCRB4tDGHoIJi 0mfkAP9yS2bi4VD6hutTCOIeT3qJB84qFVZONJYP1wnhQwLGeAD8CFxZvCN6Jv4e UC/tOu6vHervFswpc7sqlf9k4hh+qQs= =wDJV -----END PGP SIGNATURE----- --qnPPSzmWE/KqIUbp--