[PATCH 0/9] dmaengine: drop unused module aliases

[PATCH 0/9] dmaengine: drop unused module aliases

[Johan Hovold]

When fixing some device leaks in the dmaengine drivers I noticed that
some them have unused module platform module aliases that can be
removed.

Included is also a related clean up.

Johan


Johan Hovold (9):
  dmaengine: bcm2835: drop unused module alias
  dmaengine: dw: drop unused module alias
  dmaengine: fsl-edma: drop unused module alias
  dmaengine: fsl-qdma: drop unused module alias
  dmaengine: k3dma: drop unused module alias
  dmaengine: mmp_tdma: drop unused module alias
  dmaengine: mmp_tdma: drop unnecessary OF node check in remove
  dmaengine: sprd: drop unused module alias
  dmaengine: tegra210-adma: drop unused module alias

 drivers/dma/bcm2835-dma.c   | 1 -
 drivers/dma/dw/platform.c   | 5 +----
 drivers/dma/fsl-edma-main.c | 1 -
 drivers/dma/fsl-qdma.c      | 1 -
 drivers/dma/k3dma.c         | 1 -
 drivers/dma/mmp_tdma.c      | 4 +---
 drivers/dma/sprd-dma.c      | 1 -
 drivers/dma/tegra210-adma.c | 1 -
 8 files changed, 2 insertions(+), 13 deletions(-)

-- 
2.51.2

[PATCH 1/9] dmaengine: bcm2835: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/bcm2835-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 0117bb2e8591..321748e2983e 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -1060,7 +1060,6 @@ static struct platform_driver bcm2835_dma_driver = {
 
 module_platform_driver(bcm2835_dma_driver);
 
-MODULE_ALIAS("platform:bcm2835-dma");
 MODULE_DESCRIPTION("BCM2835 DMA engine driver");
 MODULE_AUTHOR("Florian Meier <florian.meier@koalo.de>");
 MODULE_LICENSE("GPL");
-- 
2.51.2

[PATCH 2/9] dmaengine: dw: drop unused module alias

[Johan Hovold]

The driver does not support anything but OF and ACPI probe since commit
b3757413b91e ("dmaengine: dw: platform: Use struct dw_dma_chip_pdata")
so drop the unused platform module alias along with the now unnecessary
driver name define.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/dw/platform.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
index cee56cd31a61..c63fa52036d7 100644
--- a/drivers/dma/dw/platform.c
+++ b/drivers/dma/dw/platform.c
@@ -21,8 +21,6 @@
 
 #include "internal.h"
 
-#define DRV_NAME	"dw_dmac"
-
 static int dw_probe(struct platform_device *pdev)
 {
 	const struct dw_dma_chip_pdata *match;
@@ -190,7 +188,7 @@ static struct platform_driver dw_driver = {
 	.remove		= dw_remove,
 	.shutdown       = dw_shutdown,
 	.driver = {
-		.name	= DRV_NAME,
+		.name	= "dw_dmac",
 		.pm	= pm_sleep_ptr(&dw_dev_pm_ops),
 		.of_match_table = of_match_ptr(dw_dma_of_id_table),
 		.acpi_match_table = ACPI_PTR(dw_dma_acpi_id_table),
@@ -211,4 +209,3 @@ module_exit(dw_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Synopsys DesignWare DMA Controller platform driver");
-MODULE_ALIAS("platform:" DRV_NAME);
-- 
2.51.2

Re: [PATCH 2/9] dmaengine: dw: drop unused module alias

[Andy Shevchenko]

On Thu, Nov 20, 2025 at 12:45:17PM +0100, Johan Hovold wrote:
> The driver does not support anything but OF and ACPI probe since commit
> b3757413b91e ("dmaengine: dw: platform: Use struct dw_dma_chip_pdata")
> so drop the unused platform module alias along with the now unnecessary
> driver name define.

I think de facto it happened earlier, but whatever.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for the contribution to this driver!

-- 
With Best Regards,
Andy Shevchenko

[PATCH 3/9] dmaengine: fsl-edma: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/fsl-edma-main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 97583c7d51a2..a753b7cbfa7a 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -999,6 +999,5 @@ static void __exit fsl_edma_exit(void)
 }
 module_exit(fsl_edma_exit);
 
-MODULE_ALIAS("platform:fsl-edma");
 MODULE_DESCRIPTION("Freescale eDMA engine driver");
 MODULE_LICENSE("GPL v2");
-- 
2.51.2

Re: [PATCH 3/9] dmaengine: fsl-edma: drop unused module alias

[Frank Li]

On Thu, Nov 20, 2025 at 12:45:18PM +0100, Johan Hovold wrote:
> The driver has never supported anything but OF probe so drop the unused
> platform module alias.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/dma/fsl-edma-main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 97583c7d51a2..a753b7cbfa7a 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -999,6 +999,5 @@ static void __exit fsl_edma_exit(void)
>  }
>  module_exit(fsl_edma_exit);
>
> -MODULE_ALIAS("platform:fsl-edma");
>  MODULE_DESCRIPTION("Freescale eDMA engine driver");
>  MODULE_LICENSE("GPL v2");
> --
> 2.51.2
>

[PATCH 4/9] dmaengine: fsl-qdma: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/fsl-qdma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index 21e13f1207cb..6ace5bf80c40 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -1296,6 +1296,5 @@ static struct platform_driver fsl_qdma_driver = {
 
 module_platform_driver(fsl_qdma_driver);
 
-MODULE_ALIAS("platform:fsl-qdma");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("NXP Layerscape qDMA engine driver");
-- 
2.51.2

Re: [PATCH 4/9] dmaengine: fsl-qdma: drop unused module alias

[Frank Li]

On Thu, Nov 20, 2025 at 12:45:19PM +0100, Johan Hovold wrote:
> The driver has never supported anything but OF probe so drop the unused
> platform module alias.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>  drivers/dma/fsl-qdma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index 21e13f1207cb..6ace5bf80c40 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -1296,6 +1296,5 @@ static struct platform_driver fsl_qdma_driver = {
>
>  module_platform_driver(fsl_qdma_driver);
>
> -MODULE_ALIAS("platform:fsl-qdma");
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("NXP Layerscape qDMA engine driver");
> --
> 2.51.2
>

Re: [PATCH 4/9] dmaengine: fsl-qdma: drop unused module alias

[Frank Li]

On Thu, Nov 20, 2025 at 12:45:19PM +0100, Johan Hovold wrote:
> The driver has never supported anything but OF probe so drop the unused
> platform module alias.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/fsl-qdma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index 21e13f1207cb..6ace5bf80c40 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -1296,6 +1296,5 @@ static struct platform_driver fsl_qdma_driver = {
>
>  module_platform_driver(fsl_qdma_driver);
>
> -MODULE_ALIAS("platform:fsl-qdma");
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("NXP Layerscape qDMA engine driver");
> --
> 2.51.2
>

[PATCH 5/9] dmaengine: k3dma: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/k3dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index acc2983e28e0..0f9cd7815f88 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -1034,5 +1034,4 @@ static struct platform_driver k3_pdma_driver = {
 module_platform_driver(k3_pdma_driver);
 
 MODULE_DESCRIPTION("HiSilicon k3 DMA Driver");
-MODULE_ALIAS("platform:k3dma");
 MODULE_LICENSE("GPL v2");
-- 
2.51.2

[PATCH 6/9] dmaengine: mmp_tdma: drop unused module alias

[Johan Hovold]

The driver does not support anything but OF probe since commit
3b0f4a54f247 ("dma:mmp_tdma: get sram pool through device tree") so drop
the unused platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/mmp_tdma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index b7fb843c67a6..6186b9dc5457 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -743,6 +743,5 @@ module_platform_driver(mmp_tdma_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("MMP Two-Channel DMA Driver");
-MODULE_ALIAS("platform:mmp-tdma");
 MODULE_AUTHOR("Leo Yan <leoy@marvell.com>");
 MODULE_AUTHOR("Zhangfei Gao <zhangfei.gao@marvell.com>");
-- 
2.51.2

[PATCH 7/9] dmaengine: mmp_tdma: drop unnecessary OF node check in remove

[Johan Hovold]

The driver does not support anything but OF probe since commit
3b0f4a54f247 ("dma:mmp_tdma: get sram pool through device tree").

Commit a67ba97dfb30 ("dmaengine: Use device_get_match_data()") later
removed most remnants of platform probing except for an unnecessary OF
node check in remove().

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/mmp_tdma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index 6186b9dc5457..ba03321eeff7 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -554,8 +554,7 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)
 
 static void mmp_tdma_remove(struct platform_device *pdev)
 {
-	if (pdev->dev.of_node)
-		of_dma_controller_free(pdev->dev.of_node);
+	of_dma_controller_free(pdev->dev.of_node);
 }
 
 static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev,
-- 
2.51.2

[PATCH 8/9] dmaengine: sprd: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/sprd-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 187a090463ce..6207e0b185e1 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -1311,4 +1311,3 @@ MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DMA driver for Spreadtrum");
 MODULE_AUTHOR("Baolin Wang <baolin.wang@spreadtrum.com>");
 MODULE_AUTHOR("Eric Long <eric.long@spreadtrum.com>");
-MODULE_ALIAS("platform:sprd-dma");
-- 
2.51.2

[PATCH 9/9] dmaengine: tegra210-adma: drop unused module alias

[Johan Hovold]

The driver has never supported anything but OF probe so drop the unused
platform module alias.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/dma/tegra210-adma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index fad896ff29a2..d0e8bb27a03b 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -1230,7 +1230,6 @@ static struct platform_driver tegra_admac_driver = {
 
 module_platform_driver(tegra_admac_driver);
 
-MODULE_ALIAS("platform:tegra210-adma");
 MODULE_DESCRIPTION("NVIDIA Tegra ADMA driver");
 MODULE_AUTHOR("Dara Ramesh <dramesh@nvidia.com>");
 MODULE_AUTHOR("Jon Hunter <jonathanh@nvidia.com>");
-- 
2.51.2

Re: [PATCH 9/9] dmaengine: tegra210-adma: drop unused module alias

[Jon Hunter]

On 20/11/2025 11:45, Johan Hovold wrote:
> The driver has never supported anything but OF probe so drop the unused
> platform module alias.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>   drivers/dma/tegra210-adma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index fad896ff29a2..d0e8bb27a03b 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -1230,7 +1230,6 @@ static struct platform_driver tegra_admac_driver = {
>   
>   module_platform_driver(tegra_admac_driver);
>   
> -MODULE_ALIAS("platform:tegra210-adma");
>   MODULE_DESCRIPTION("NVIDIA Tegra ADMA driver");
>   MODULE_AUTHOR("Dara Ramesh <dramesh@nvidia.com>");
>   MODULE_AUTHOR("Jon Hunter <jonathanh@nvidia.com>");


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic

Re: [PATCH 0/9] dmaengine: drop unused module aliases

[Vinod Koul]

On Thu, 20 Nov 2025 12:45:15 +0100, Johan Hovold wrote:
> When fixing some device leaks in the dmaengine drivers I noticed that
> some them have unused module platform module aliases that can be
> removed.
> 
> Included is also a related clean up.
> 
> Johan
> 
> [...]

Applied, thanks!

[1/9] dmaengine: bcm2835: drop unused module alias
      commit: bfab38bee5652f335c5d693d54eb61bc25850518
[2/9] dmaengine: dw: drop unused module alias
      commit: 660c40702d9073035c61a9573b299481b9c7f3cd
[3/9] dmaengine: fsl-edma: drop unused module alias
      commit: 03adb0eb0ed64a1e13e04c0fb57a073896efe6ca
[4/9] dmaengine: fsl-qdma: drop unused module alias
      commit: 9180a66fb43214ae02311176e43eec361ff80d67
[5/9] dmaengine: k3dma: drop unused module alias
      commit: 73b77c3d80031b4636a24912962ffeb295438b0a
[6/9] dmaengine: mmp_tdma: drop unused module alias
      commit: 73391fecf23860804bceb6670cef74a3626ecf92
[7/9] dmaengine: mmp_tdma: drop unnecessary OF node check in remove
      commit: 3b7b0bbdcba984287225bb373e52845c23dadb93
[8/9] dmaengine: sprd: drop unused module alias
      commit: 1911f507a54b42bd01ae30590c06d8140beee424
[9/9] dmaengine: tegra210-adma: drop unused module alias
      commit: e0aef2a5c33680bbd332e5b5f64afc8dde8d46f6

Best regards,
-- 
~Vinod