Re: [PATCH v2 16/19] dt-bindings: pinctrl: pinctrl-microchip-sgpio: add LAN969x

Conor Dooley
2025-12-22T20:52:28Z

[-- Attachment #1: Type: text/plain, Size: 2431 bytes --]

On Mon, Dec 22, 2025 at 08:57:14PM +0100, Robert Marko wrote:
> On Tue, Dec 16, 2025 at 6:34 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Mon, Dec 15, 2025 at 05:35:33PM +0100, Robert Marko wrote:
> > > Document LAN969x compatibles for SGPIO.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > > ---
> > > .../pinctrl/microchip,sparx5-sgpio.yaml | 20 ++++++++++++++-----
> > > 1 file changed, 15 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > index fa47732d7cef..9fbbafcdc063 100644
> > > --- a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > @@ -21,10 +21,15 @@ properties:
> > > pattern: '^gpio@[0-9a-f]+$'
> > >
> > > compatible:
> > > - enum:
> > > - - microchip,sparx5-sgpio
> > > - - mscc,ocelot-sgpio
> > > - - mscc,luton-sgpio
> > > + oneOf:
> > > + - enum:
> > > + - microchip,sparx5-sgpio
> > > + - mscc,ocelot-sgpio
> > > + - mscc,luton-sgpio
> > > + - items:
> > > + - enum:
> > > + - microchip,lan9691-sgpio
> > > + - const: microchip,sparx5-sgpio
> > >
> > > '#address-cells':
> > > const: 1
> > > @@ -80,7 +85,12 @@ patternProperties:
> > > type: object
> > > properties:
> > > compatible:
> > > - const: microchip,sparx5-sgpio-bank
> >
> > This should just be able to become "compatible: contains: const: microchip,sparx5-sgpio-bank.
> > pw-bot: changes-requested
>
> Hi Conor,
> I have tried using contains, but it would fail to match with the
> following error:
> arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dtb:
> /axi/gpio@e2010230/gpio@0: failed to match any schema with compatible:
> ['microchip,lan9691-sgpio-bank', 'microchip,sparx5-sgpio-bank']
> arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dtb:
> /axi/gpio@e2010230/gpio@1: failed to match any schema with compatible:
> ['microchip,lan9691-sgpio-bank', 'microchip,sparx5-sgpio-bank']

Oh, I think I cocked up here and thought this was some restriction
imposition but it's a child with a compatible. My bad.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]