* [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups
@ 2026-01-24 2:45 Khairul Anuar Romli
2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Khairul Anuar Romli @ 2026-01-24 2:45 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, dmaengine, linux-kernel,
Khairul Anuar Romli
This series contains a single patch that fixes minor coding style
issues in the Synopsys DesignWare AXI DMA Controller platform driver.
The changes are purely cosmetic:
- Adjust indentation of function arguments and debug messages
- Remove an unnecessary `return;` statement
- Add a blank line for readability between functions
These updates improve code readability and maintain consistency with
kernel coding style guidelines. No functional changes are introduced.
---
Notes:
This patch series is applied on dmaengine maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next
Changes in v3:
- Split into smaller patches based on warning type
Changes in v2:
- Rebase on top of newer merge commit
v1:
https://lore.kernel.org/all/20260104093529.40913-1-karom.9560@gmail.com/
---
Khairul Anuar Romli (3):
dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
dmaengine: dw-axi-dmac: Add blank line after function
dmaengine: dw-axi-dmac: Remove not useful void return function
statements
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis 2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli @ 2026-01-24 2:45 ` Khairul Anuar Romli 2026-01-24 9:05 ` Markus Elfring 2026-01-24 2:45 ` [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli 2 siblings, 1 reply; 6+ messages in thread From: Khairul Anuar Romli @ 2026-01-24 2:45 UTC (permalink / raw) To: Eugeniy Paltsev, Vinod Koul, dmaengine, linux-kernel, Khairul Anuar Romli Check warning is throws when run scripts/checkpatch.pl --strict: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:345 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:356 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:494 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1165 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1454 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1648 Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com> --- Changes in v3: - Split the patch into smaller patches according type of warning. Changes in v2: - rebase on top of 3c8a86ed002a "dmaengine: xilinx: xdma: use sg_nents_for_dma() helper" - refactor the commit title Reference to v1: https://lore.kernel.org/all/20260104093529.40913-1-karom.9560@gmail.com/ --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 17 ++++++++--------- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 493c2a32b0fe..8bb97fb8fd4c 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -342,8 +342,8 @@ static void axi_desc_put(struct axi_dma_desc *desc) kfree(desc); atomic_sub(descs_put, &chan->descs_allocated); dev_vdbg(chan2dev(chan), "%s: %d descs put, %d still allocated\n", - axi_chan_name(chan), descs_put, - atomic_read(&chan->descs_allocated)); + axi_chan_name(chan), descs_put, + atomic_read(&chan->descs_allocated)); } static void vchan_desc_put(struct virt_dma_desc *vdesc) @@ -353,7 +353,7 @@ static void vchan_desc_put(struct virt_dma_desc *vdesc) static enum dma_status dma_chan_tx_status(struct dma_chan *dchan, dma_cookie_t cookie, - struct dma_tx_state *txstate) + struct dma_tx_state *txstate) { struct axi_dma_chan *chan = dchan_to_axi_dma_chan(dchan); struct virt_dma_desc *vdesc; @@ -491,7 +491,7 @@ static void axi_chan_start_first_queued(struct axi_dma_chan *chan) desc = vd_to_axi_desc(vd); dev_vdbg(chan2dev(chan), "%s: started %u\n", axi_chan_name(chan), - vd->tx.cookie); + vd->tx.cookie); axi_chan_block_xfer_start(chan, desc); } @@ -1162,7 +1162,7 @@ static irqreturn_t dw_axi_dma_interrupt(int irq, void *dev_id) axi_chan_irq_clear(chan, status); dev_vdbg(chip->dev, "%s %u IRQ status: 0x%08x\n", - axi_chan_name(chan), i, status); + axi_chan_name(chan), i, status); if (status & DWAXIDMAC_IRQ_ALL_ERR) axi_chan_handle_err(chan, status); @@ -1451,7 +1451,7 @@ static int axi_req_irqs(struct platform_device *pdev, struct axi_dma_chip *chip) if (chip->irq[i] < 0) return chip->irq[i]; ret = devm_request_irq(chip->dev, chip->irq[i], dw_axi_dma_interrupt, - IRQF_SHARED, KBUILD_MODNAME, chip); + IRQF_SHARED, KBUILD_MODNAME, chip); if (ret < 0) return ret; } @@ -1645,7 +1645,7 @@ static void dw_remove(struct platform_device *pdev) of_dma_controller_free(chip->dev->of_node); list_for_each_entry_safe(chan, _chan, &dw->dma.channels, - vc.chan.device_node) { + vc.chan.device_node) { list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); } -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis 2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli @ 2026-01-24 9:05 ` Markus Elfring 2026-01-24 12:32 ` Khairul Anuar Romli 0 siblings, 1 reply; 6+ messages in thread From: Markus Elfring @ 2026-01-24 9:05 UTC (permalink / raw) To: Khairul Anuar Romli, dmaengine; +Cc: LKML, Eugeniy Paltsev, Vinod Koul > Check warning is throws when run scripts/checkpatch.pl --strict: > drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:345 Please improve such a change description another bit. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n45 You might not need to mention all affected source code positions here. … > --- > Changes in v3: > - Split the patch into smaller patches according type > of warning. … * I find this hint relevant also for a better commit message. * You do not need to repeat patch version descriptions here after you provided them in the cover letter already. Regards, Markus ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis 2026-01-24 9:05 ` Markus Elfring @ 2026-01-24 12:32 ` Khairul Anuar Romli 0 siblings, 0 replies; 6+ messages in thread From: Khairul Anuar Romli @ 2026-01-24 12:32 UTC (permalink / raw) To: Markus Elfring, dmaengine; +Cc: LKML, Eugeniy Paltsev, Vinod Koul On 24/1/2026 5:05 pm, Markus Elfring wrote: >> Check warning is throws when run scripts/checkpatch.pl --strict: >> drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:345 > > Please improve such a change description another bit. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n45 > > You might not need to mention all affected source code positions here. > I will improve the change description and omit mentioning all the affected source code in the next revision. > > … >> --- >> Changes in v3: >> - Split the patch into smaller patches according type >> of warning. > … > > * I find this hint relevant also for a better commit message. > > * You do not need to repeat patch version descriptions here > after you provided them in the cover letter already. > Noted. Will keep to the cover letter and avoid repeating the same description in every single patch. > > Regards, > Markus ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function 2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli @ 2026-01-24 2:45 ` Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli 2 siblings, 0 replies; 6+ messages in thread From: Khairul Anuar Romli @ 2026-01-24 2:45 UTC (permalink / raw) To: Eugeniy Paltsev, Vinod Koul, dmaengine, linux-kernel, Khairul Anuar Romli scripts/checkpatch.pl --strict throws CHECK: Please use a blank line after function/struct/union/enum declarations: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:422 Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com> --- Changes in v3: - Split the patch into smaller patches according type of warning. Changes in v2: - rebase on top of 3c8a86ed002a "dmaengine: xilinx: xdma: use sg_nents_for_dma() helper" - refactor the commit title Reference to v1: https://lore.kernel.org/all/20260104093529.40913-1-karom.9560@gmail.com/ --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 + drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 8bb97fb8fd4c..e59725376f8e 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -419,6 +419,7 @@ static void dw_axi_dma_set_byte_halfword(struct axi_dma_chan *chan, bool set) iowrite32(val, chan->chip->apb_regs + offset); } + /* Called in chan locked context */ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan, struct axi_dma_desc *first) -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements 2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli @ 2026-01-24 2:45 ` Khairul Anuar Romli 2 siblings, 0 replies; 6+ messages in thread From: Khairul Anuar Romli @ 2026-01-24 2:45 UTC (permalink / raw) To: Eugeniy Paltsev, Vinod Koul, dmaengine, linux-kernel, Khairul Anuar Romli scripts/checkpatch.pl --strict throws void function return statements are not generally useful: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:598 Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com> --- Changes in v3: - Split the patch into smaller patches according type of warning. Changes in v2: - rebase on top of 3c8a86ed002a "dmaengine: xilinx: xdma: use sg_nents_for_dma() helper" - refactor the commit title Reference to v1: https://lore.kernel.org/all/20260104093529.40913-1-karom.9560@gmail.com/ --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 17 ++++++++--------- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index e59725376f8e..c124ac6c8df6 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set) (chan->id * DMA_APB_HS_SEL_BIT_SIZE)); reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE)); lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0); - - return; } /* -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-24 12:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli 2026-01-24 9:05 ` Markus Elfring 2026-01-24 12:32 ` Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli 2026-01-24 2:45 ` [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox