From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Khairul Anuar Romli <karom.9560@gmail.com>
Subject: [PATCH v3 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements
Date: Sat, 24 Jan 2026 10:45:39 +0800 [thread overview]
Message-ID: <20260124024539.21110-4-karom.9560@gmail.com> (raw)
In-Reply-To: <20260124024539.21110-1-karom.9560@gmail.com>
scripts/checkpatch.pl --strict throws
void function return statements are not generally useful:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:598
Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
Changes in v3:
- Split the patch into smaller patches according type
of warning.
Changes in v2:
- rebase on top of 3c8a86ed002a "dmaengine: xilinx: xdma: use
sg_nents_for_dma() helper"
- refactor the commit title
Reference to v1:
https://lore.kernel.org/all/20260104093529.40913-1-karom.9560@gmail.com/
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 17 ++++++++---------
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index e59725376f8e..c124ac6c8df6 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
(chan->id * DMA_APB_HS_SEL_BIT_SIZE));
reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0);
-
- return;
}
/*
--
2.43.0
prev parent reply other threads:[~2026-01-24 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 2:45 [PATCH v3 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-01-24 2:45 ` [PATCH v3 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-01-24 9:05 ` Markus Elfring
2026-01-24 12:32 ` Khairul Anuar Romli
2026-01-24 2:45 ` [PATCH v3 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-01-24 2:45 ` Khairul Anuar Romli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260124024539.21110-4-karom.9560@gmail.com \
--to=karom.9560@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox