From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus.Elfring@web.de, Khairul Anuar Romli <karom.9560@gmail.com>
Subject: [PATCH v6 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements
Date: Sun, 1 Feb 2026 08:04:52 +0800 [thread overview]
Message-ID: <20260201000500.11882-4-karom.9560@gmail.com> (raw)
In-Reply-To: <20260201000500.11882-1-karom.9560@gmail.com>
The dw_axi_dma_set_hw_channel() function is declared as void, so an
explicit `return;` at the end is unnecessary. Control flow naturally
returns to the caller once the function ends. Removing it cleans up the
code and aligns with kernel style guidelines without changing
functionality.
This fix resolves a coding style issue introduced by
- 'commit 32286e279385 ("dmaengine: dw-axi-dmac: Remove free slot check
algorithm in dw_axi_dma_set_hw_channel")'.
This unnecessary return were detected with the help of the checkpatch.pl
analysis tool with --strict --file option.
Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index e59725376f8e..c124ac6c8df6 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
(chan->id * DMA_APB_HS_SEL_BIT_SIZE));
reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0);
-
- return;
}
/*
--
2.43.0
next prev parent reply other threads:[~2026-02-01 0:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 0:04 [PATCH v6 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-02-01 0:04 ` [PATCH v6 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-02-01 8:34 ` Markus Elfring
2026-02-01 0:04 ` [PATCH v6 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-02-01 8:44 ` Markus Elfring
2026-02-01 0:04 ` Khairul Anuar Romli [this message]
2026-02-01 8:51 ` [PATCH v6 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Markus Elfring
2026-02-02 4:57 ` Khairul Anuar Romli
2026-02-01 9:57 ` [v6 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Markus Elfring
2026-02-02 4:38 ` Khairul Anuar Romli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260201000500.11882-4-karom.9560@gmail.com \
--to=karom.9560@gmail.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Markus.Elfring@web.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox