public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	Markus.Elfring@web.de, Khairul Anuar Romli <karom.9560@gmail.com>
Subject: [PATCH v7 2/3] dmaengine: dw-axi-dmac: Add blank line after function
Date: Mon,  2 Feb 2026 14:02:18 +0800	[thread overview]
Message-ID: <20260202060224.12616-3-karom.9560@gmail.com> (raw)
In-Reply-To: <20260202060224.12616-1-karom.9560@gmail.com>

checkpatch.pl reports a CHECK warning in dw-axi-dmac-platform.c:

  CHECK: Please use a blank line after function/struct/union/enum
  declarations
  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:

The Linux kernel coding style [Documentation/process/coding-style.rst]
requires a blank line after function definitions to provide visual
separation between distinct code elements.

This patch inserts the required blank line after the closing brace of the
function definition after dw_axi_dma_set_byte_halfword(), placing it
before the contextual comment that describes the locking requirements.

Fixes: 82b5c9d6d4de ("dmaengine: dw-axi-dmac: Add Intel KeemBay AxiDMA BYTE and HALFWORD registers")
Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
v6 -> v7:
    - Refine the details that was not included in v6.
    - Add Fixes that was not mentioned earlier.

Reference to v6:
https://lore.kernel.org/all/20260201000500.11882-3-karom.9560@gmail.com/
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 8bb97fb8fd4c..e59725376f8e 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -419,6 +419,7 @@ static void dw_axi_dma_set_byte_halfword(struct axi_dma_chan *chan, bool set)
 
 	iowrite32(val, chan->chip->apb_regs + offset);
 }
+
 /* Called in chan locked context */
 static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
 				      struct axi_dma_desc *first)
-- 
2.43.0


  parent reply	other threads:[~2026-02-02  6:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  6:02 [PATCH v7 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-02-02  6:02 ` [PATCH v7 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-02-02  6:26   ` Markus Elfring
2026-02-02 11:58     ` Khairul Anuar Romli
2026-02-02  6:02 ` Khairul Anuar Romli [this message]
2026-02-02  6:02 ` [PATCH 3/3] dmaengine: dw-axi-dmac: Remove unnecessary return statement from void function Khairul Anuar Romli
2026-02-02 15:20 ` [PATCH v7 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Markus Elfring
2026-02-25 11:24 ` Vinod Koul
2026-02-28  0:30   ` Khairul Anuar Romli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260202060224.12616-3-karom.9560@gmail.com \
    --to=karom.9560@gmail.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=Markus.Elfring@web.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox