public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	Markus.Elfring@web.de, Khairul Anuar Romli <karom.9560@gmail.com>
Subject: [PATCH 3/3] dmaengine: dw-axi-dmac: Remove unnecessary return statement from void function
Date: Mon,  2 Feb 2026 14:02:19 +0800	[thread overview]
Message-ID: <20260202060224.12616-4-karom.9560@gmail.com> (raw)
In-Reply-To: <20260202060224.12616-1-karom.9560@gmail.com>

checkpatch.pl --strict reports a WARNING in dw-axi-dmac-platform.c:

  WARNING: void function return statements are not generally useful
  FILE: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

According to Linux kernel coding style [Documentation/process/
coding-style.rst], explicit "return;" statements at the end of void
functions are redundant and should be omitted. The function will
automatically return upon reaching the closing brace, so the extra
statement adds unnecessary clutter without functional benefit.

This patch removes the superfluous "return;" statement in
dw_axi_dma_set_hw_channel() to comply with kernel coding standards and
eliminate the checkpatch warning.

Fixes: 32286e279385 ("dmaengine: dw-axi-dmac: Remove free slot check algorithm in dw_axi_dma_set_hw_channel")
Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
v6 -> v7:
    - Make slightly adjustment to the commit title to reflect exactly to
      what the patch is address.
    - Refine the details in the patch summary.
    - Move the commit that the patch try to fix to Fixes.

Reference to v6:
https://lore.kernel.org/all/20260201000500.11882-4-karom.9560@gmail.com/
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index e59725376f8e..c124ac6c8df6 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
 			(chan->id * DMA_APB_HS_SEL_BIT_SIZE));
 	reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
 	lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0);
-
-	return;
 }
 
 /*
-- 
2.43.0


  parent reply	other threads:[~2026-02-02  6:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  6:02 [PATCH v7 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-02-02  6:02 ` [PATCH v7 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-02-02  6:26   ` Markus Elfring
2026-02-02 11:58     ` Khairul Anuar Romli
2026-02-02  6:02 ` [PATCH v7 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-02-02  6:02 ` Khairul Anuar Romli [this message]
2026-02-02 15:20 ` [PATCH v7 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Markus Elfring
2026-02-25 11:24 ` Vinod Koul
2026-02-28  0:30   ` Khairul Anuar Romli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260202060224.12616-4-karom.9560@gmail.com \
    --to=karom.9560@gmail.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=Markus.Elfring@web.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox