Re: [PATCH] dmaengine: amd: Replace deprecated PCI functions

[kernel test robot <lkp@intel.com>]

Hi Philipp,

kernel test robot noticed the following build errors:

[auto build test ERROR on vkoul-dmaengine/next]
[also build test ERROR on linus/master v6.19-rc8 next-20260202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/dmaengine-amd-Replace-deprecated-PCI-functions/20260203-204040
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link:    https://lore.kernel.org/r/20260203123238.88598-2-phasta%40kernel.org
patch subject: [PATCH] dmaengine: amd: Replace deprecated PCI functions
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20260204/202602040405.NuKnq4rr-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602040405.NuKnq4rr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602040405.NuKnq4rr-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/dma/amd/ae4dma/ae4dma-pci.c:11:
   In file included from drivers/dma/amd/ae4dma/ae4dma.h:14:
   In file included from include/linux/dmaengine.h:12:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/um/include/asm/io.h:24:
   include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
    1209 |         return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
         |                                                   ~~~~~~~~~~ ^
>> drivers/dma/amd/ae4dma/ae4dma-pci.c:80:24: error: expected ';' at end of declaration
      80 |         unsigned long bar_mask
         |                               ^
         |                               ;
   1 warning and 1 error generated.


vim +80 drivers/dma/amd/ae4dma/ae4dma-pci.c

    75	
    76	static int ae4_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
    77	{
    78		struct device *dev = &pdev->dev;
    79		struct ae4_device *ae4;
  > 80		unsigned long bar_mask
    81		struct pt_device *pt;
    82		int ret = 0;
    83		int bar;
    84	
    85		ae4 = devm_kzalloc(dev, sizeof(*ae4), GFP_KERNEL);
    86		if (!ae4)
    87			return -ENOMEM;
    88	
    89		ae4->ae4_msix = devm_kzalloc(dev, sizeof(struct ae4_msix), GFP_KERNEL);
    90		if (!ae4->ae4_msix)
    91			return -ENOMEM;
    92	
    93		ret = pcim_enable_device(pdev);
    94		if (ret)
    95			goto ae4_error;
    96	
    97		bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
    98		for_each_set_bit(bar, &bar_mask, sizeof(bar_mask)) {
    99			ret = pcim_request_region(pdev, bar, DRIVER_NAME);
   100			if (ret)
   101				goto ae4_error;
   102		}
   103	
   104		pt = &ae4->pt;
   105		pt->dev = dev;
   106		pt->ver = AE4_DMA_VERSION;
   107	
   108		pt->io_regs = pcim_iomap(pdev, 0, 0);
   109		if (!pt->io_regs) {
   110			ret = -ENOMEM;
   111			goto ae4_error;
   112		}
   113	
   114		ret = ae4_get_irqs(ae4);
   115		if (ret < 0)
   116			goto ae4_error;
   117	
   118		pci_set_master(pdev);
   119	
   120		dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48));
   121	
   122		dev_set_drvdata(dev, ae4);
   123	
   124		ret = ae4_core_init(ae4);
   125		if (ret)
   126			goto ae4_error;
   127	
   128		return 0;
   129	
   130	ae4_error:
   131		ae4_deinit(ae4);
   132	
   133		return ret;
   134	}
   135	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki