Re: [PATCH v2 3/9] dmaengine: tegra: Make reset control optional

Frank Li
2026-03-02T20:32:07Z

On Mon, Mar 02, 2026 at 06:02:33PM +0530, Akhil R wrote:
> In Tegra264, reset is not available for the driver to control as
> this is handled by the boot firmware. Hence make the reset control
> optional and update the error message to reflect the correct error.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/tegra186-gpc-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
> index 4d6fe0efa76e..09a1717aa808 100644
> --- a/drivers/dma/tegra186-gpc-dma.c
> +++ b/drivers/dma/tegra186-gpc-dma.c
> @@ -1382,10 +1382,10 @@ static int tegra_dma_probe(struct platform_device *pdev)
> if (IS_ERR(tdma->base_addr))
> return PTR_ERR(tdma->base_addr);
>
> - tdma->rst = devm_reset_control_get_exclusive(&pdev->dev, "gpcdma");
> + tdma->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, "gpcdma");
> if (IS_ERR(tdma->rst)) {
> return dev_err_probe(&pdev->dev, PTR_ERR(tdma->rst),
> - "Missing controller reset\n");
> + "Failed to get controller reset\n");
> }
> reset_control_reset(tdma->rst);
>
> --
> 2.50.1
>