Re: [PATCH v4 1/3] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine

[Rob Herring <robh@kernel.org>]

On Mon, Jun 01, 2026 at 09:58:45AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The Device Tree schema uses `additionalProperties: false` alongside an `allOf: [ { $ref: dma-controller.yaml# } ]` inclusion, which violates DT schema guidelines and prevents the use of standard generic DMA properties.
> --
> 
> commit 65ee89a1dfc4e52aa6a4083163369bef3de2c374
> Author: CL Wang <cl634@andestech.com>
> 
> dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine
> 
> This commit documents the devicetree bindings for the Andes ATCDMAC300
> DMA engine. The IP is embedded in AndesCore-based platforms or SoCs
> such as AE350 and Qilai.
> 
> > diff --git a/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> [ ... ]
> > +allOf:
> > +  - $ref: dma-controller.yaml#
> > +
> > +properties:
> [ ... ]
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - "#dma-cells"
> > +
> > +additionalProperties: false
> 
> [Severity: Low]
> Does this cause a regression during schema validation when standard DMA
> properties are used?
> 
> Since this binding references dma-controller.yaml# via an allOf block, using
> additionalProperties: false will reject generic properties like dma-channels
> or dma-requests if they are present in the device tree node. 
> 
> Should this be unevaluatedProperties: false instead to properly allow the
> inherited properties?

No, it is fine as-is.

Rob