From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634143DCDAC for ; Fri, 5 Jun 2026 22:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780696928; cv=none; b=e/FxEjb0/JrW3ZKNbeoiKm/aTpg+Eevt2re6RyTEY0CYi9izBKFroOKUPPf0KgBM2KAH4OIjkZhjhVhpUTyU5eAbxEOoipkX4/mTZZ8eYwJN8kAjExkyREPYXLAwugQqBKPNv2wenwOZFJX1EtsOTWtQROOe9y7zwhuh7RZ1SH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780696928; c=relaxed/simple; bh=jRckM7Q/DiYZgoe/UjgP6+oEblX3ejArkHyi4yqjIho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EdF+yvO9BXpcbid0nqPo7xRSTO57KvFN3WsJUUX9UWdtuyRXJFlqaoZSZfVyUbFXbPIvLbpjRkfulrh1mNL51Q55lY03M7aU09OnknGMvZXQzPRjjrwdcTyxooIw9Gc+JZlFAoMvm8b/f2M0u6aK5x363G8807+zCkaSGPi9qoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lKpRYODC; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lKpRYODC" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8423f420455so1088360b3a.3 for ; Fri, 05 Jun 2026 15:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780696927; x=1781301727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KDWu5/hG//ENwpueDa3x2k+unyGwqq6tLB7KN2pYPhY=; b=lKpRYODCRRXbxBUzk37XEHD+f31cYk6GHwifjnNINpAmHy8WY2o6aZDVyqGJ8cUFMq 0MzYAgDhPU4hNB1w7TdX+v8+xNHwX+PcqoxbZLi/302lzNpmaBBBxXPgT4s7ztWX2Yfd raV4vyzpKR0dMabuPKDR5Nubp06tKc1Ft2NwJTMdd7gaKIziR3oQ0JDbbLCJinZlzt1e GOYvbqvq4krjrnmmIsiHC3IJBrYSMNVjLzlx3E7x5TWHC1Zwrr+3vqsdJYV7xX3hVjmW zTSWTBS90hJw8wha+OkZTqOaVuZYm2nhavu/EADofYa3rgpqRsf0IH6f8rxMnFxklvjI QPXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780696927; x=1781301727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KDWu5/hG//ENwpueDa3x2k+unyGwqq6tLB7KN2pYPhY=; b=hOXNHHiXntMx9wpJ0q8+vmkoI4h39S35WDrH65HQ9kYKXtvTIOIq941BMDMY5qaAuw lXcJLLk0uiafiGv05qWUEqAFPBs//TEdze1FHz7VtKPsQpnNBBnDT4QdL0X6w4CXckWw rW3oNVKPF09YLWGUzAabucRjoYIlIm3Hdu7QhFdDnrT/FoA16DoeyrwLuJqXk25pA/az Y/R42VOVZtgVGHZeNgPF7V2ukUkXMvbcopF3KBiACrAU1UjTTc5M1wihds0TFoMVvP69 d3nu2bzfHt5XDFuQSsx2TEzUMzSBvqJkw1j/CeU08WRG23R5jGrJDSJuZWUFcZoN8+7v 3kBg== X-Gm-Message-State: AOJu0Yx79jUno5t1ZpbLgMMF9NYY1Qx/0wEp79g0ExBBPiHcPMEUf4Ug cVOMIL1n7PBPSQJE9FAAolXuHuSTe5J09NfxCjYnA2pSm1d0fRIj4T1dQPcdog== X-Gm-Gg: Acq92OFDsxBcoK+VglbbkUrk5nmVr0qt/mjU48J2pmUDS+gGtgbosyvTuKt/552lVgU tZRWbk+aiD14FcNCmZwQsU5871oLxq41oDXm7ops4Ad5izBpBj5P0+WhrZXfwwInIWJDceDRZCO RRfvAY7Od9fDCABaPdy4ZwOc7RSeRCDQXqbM+Zo0LRT22SxO8DUgVagTpAEr1V9XiK2N1osGA70 fB0GvZNvfOmqzpO2Ewb8vO9bwfu9qnMTyC5BHHXiDGxQxq6D888mb9aJqHS8C1Gp0Ri615FMhse PQW0RLXrdxHerUf3dKXdiIicJF2QrwLZW5sb/o2ltXIyGoIS0IPsQ9n1NeaCl4XQYkiHb5UOQlX dEQHUBqbn3y6J8RsKx9MNLt3MrQ4gCUoZD7akAIxDKDC1Ec2phgLkDOUaElIzUfp2EVzlRzHxD9 3hewxZ4CYilAjxJ/fUTbL+wyv/PJrpURdtDidlZ4gpdCNkAyUUv2nNW+zjxHSjaXVUj1LdV2zDg a3Mm4V1SRdd82nK3b9GDPQZCToMUUj301FXmMoQ2hAvMQ== X-Received: by 2002:a05:6a00:bc81:b0:842:2ae0:968d with SMTP id d2e1a72fcca58-842b0f6f508mr5278874b3a.32.1780696926573; Fri, 05 Jun 2026 15:02:06 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842824a1cb4sm12518883b3a.26.2026.06.05.15.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 15:02:05 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH 08/10] dmaengine: fsldma: replace irq_of_parse_and_map with of_irq_get Date: Fri, 5 Jun 2026 15:01:32 -0700 Message-ID: <20260605220134.43295-9-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260605220134.43295-1-rosenp@gmail.com> References: <20260605220134.43295-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use of_irq_get which returns a negative error code on failure instead of silently returning 0. Update the IRQ validation checks in fsldma_request_irqs from !chan->irq to chan->irq <= 0 to handle both 0 and negative error returns correctly. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 0d73ce3dbfe6..79a268139b9f 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1067,7 +1067,7 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) if (!chan) continue; - if (!chan->irq) { + if (chan->irq <= 0) { chan_err(chan, "interrupts property missing in device tree\n"); ret = -ENODEV; goto out_unwind; @@ -1090,7 +1090,7 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) if (!chan) continue; - if (!chan->irq) + if (chan->irq <= 0) continue; free_irq(chan->irq, chan); @@ -1180,7 +1180,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, dma_cookie_init(&chan->common); /* find the IRQ line, if it exists in the device tree */ - chan->irq = irq_of_parse_and_map(node, 0); + chan->irq = of_irq_get(node, 0); /* Add the channel to DMA device channel list */ list_add_tail(&chan->common.device_node, &fdev->common.channels); -- 2.54.0