From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E224E48A2DE for ; Tue, 9 Jun 2026 22:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043598; cv=none; b=u0tMNHAFlneohx3lKKIN9HuQOWXkl2Xwh3xrnjhuFghDZPPRQ3qx3uu08MHC16fPlcq83PhCbvKdFVLBs5DeXZbNnl/oXYhnmmxF76JAV/XNJt2nLGZZreNDTcvVAkS4Qq1nDNXRZSPyK087LR2hTpjUKQg1CLWQgCt63Zgzlqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043598; c=relaxed/simple; bh=lyTXMgabiZFV1r5MchNd6Qy8eKJqo3LxCHLLSTQ8EzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xa5N9TNLX/lTdez3B6BJ9AVGcHaCIDjZbjUuXP/YeWpW9IsFcE9HTpUOIL9MLqhjrLIMUvsktu6WC6ftQvAuLHMhVptK+nqrIrnMmN58HvOt2REAr5kBDhOlWDF4pobkLPGGqE678TWOgDAPlu7IzeocYvdFuwWkdvkBCbj//cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RKdQ/v1u; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RKdQ/v1u" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c855599a77aso3016759a12.0 for ; Tue, 09 Jun 2026 15:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781043596; x=1781648396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=RKdQ/v1uAFcxV/ocjx5v6hRmdWG+zS35WfgBSYeRthUQa93HZ0ES+XI4rB8m2KaqkF g5jDDUogZrFBdnv80jOgkkU+qQYH/WSewqkNeIUynlU/QdG731kv0Tc/+Go/xK34T9Gh NsQOA09KqGg5pYGcJCwZo3K2TjHj7z0/MVIg1OtbHBIxZhXXowxJ0VdX/JG2AGGKFgTt IXRUYb0a0HHXO/KBHQ8wztWifJEAqTGCby1RDVCr4t66/qKYWJmVNd4qBJ1XoY4oaJAP peD+TBSnwRgW7nYtzIhWEHUmjz2ab8SRbIOgsu6iB/7zMU4fih5F08KDiI8geU5okjKE UCAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781043596; x=1781648396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=bdPBSHncbBELYc95Cp+SyeCVQbo/uMRvuk1ld2pmPFBLgtnuv/sF066tlLIfOwKF+r 72NWCno6Tp2XcS2uMJc5on2VAg4svOT8v9Su4QQK9f21ft4OidYV1qFPs3HTdD67+PNp 4BfX/UOMrA+qqsoLCbL8+WhGTEyGj6pDh3u7K4uXythgU0kkGas48U5rEsuZP/qUkcz7 nV0TMAaPJb6gfRtUg9l90bAx24lXZ+nekUsAk/uxqJqA4fPG6BCHXJZb9iN2YgORopku jyIQLmTh+M5vMAY8Dag5C0FWCoStbSWgop9dVF1b9eTtSGz8Iu2IAedXSu5UatLcUEUa +vHg== X-Gm-Message-State: AOJu0Yz8R4I+7ke8z+mN1dCIe41xfNJ9DyFoLewLMg2IJ8bsVk+D0ubq Om9BpjqPDSt9amvpwllQ4qy7DBFrE8xb2JRYALqeLIyUnnKifU/g+4OS1vxI9wKk X-Gm-Gg: Acq92OFjDHG199xTDCE7sefm+v4uDpZm7Hu3FB1pcFLZNfUHWr45UqGS/wxoNitc5Y7 /cjSKEpgqk3IXZcHwD9st5yxOMweSurYi4DoZhpxjEjoHKPgO3TxlKiKQx/Nra67X37HL/M/A9c vFnb/nTwUqBdP+bf2KnlvVHQldOtI1Nd00gJYwqjz4oiur9nPVY9TLJMzhw6uOetxh8H+Ct9rHj or8cmNtcwf/kta35FWnN0UD/gNjbZGRGdk/GAiu7JZzb+pCM1tJMTInYJDf51AQID8WSq43Sf+Y dFavGC7KcTL3ILT141oMYh3Dm+Qk3YE3RCUve0igmPuwfuTHg+Y5PXOFCZtcAuv4WiHjxwe8V7d MIyts92mE4sl9sJhC88yrFInRz7l+Z9ReDa8jAjzYd/xolgu3d0SwYxe/k6QUllLQ78+Wte4kO+ kEvGTtUA9cz2dMztWUhfV5XxklF6ZD62oJ3tcWIhxlKbgBXbg/zpgejXK21pls1EJW0m/FpCNHm zGBmEpecFJ4huQCykrsXxg3WXMvLON/a6cFuzRMPzQoZA== X-Received: by 2002:a05:6a21:7a82:b0:3b4:85db:1bea with SMTP id adf61e73a8af0-3b4ccd1b486mr26738313637.5.1781043596210; Tue, 09 Jun 2026 15:19:56 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04ff24sm19661834a12.14.2026.06.09.15.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 15:19:55 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv3 05/15] dmaengine: fsldma: check dma_async_device_register() return value Date: Tue, 9 Jun 2026 15:19:16 -0700 Message-ID: <20260609221926.35538-6-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609221926.35538-1-rosenp@gmail.com> References: <20260609221926.35538-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the return value of dma_async_device_register() in the probe path and propagate errors instead of silently returning success. Previously, a registration failure would cause a NULL pointer dereference in list_del_rcu() during remove when dma_async_device_unregister() tried to remove the device's global_node from a list it was never added to. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 43d817f6ded1..3009e1531292 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1303,7 +1303,11 @@ static int fsldma_of_probe(struct platform_device *op) goto out_free_fdev; } - dma_async_device_register(&fdev->common); + err = dma_async_device_register(&fdev->common); + if (err) { + dev_err(fdev->dev, "unable to register DMA device\n"); + goto out_free_fdev; + } return 0; out_free_fdev: -- 2.54.0