DMA Engine development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	 "David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>,
	 Vinod Koul <vkoul@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Frank Li <Frank.Li@kernel.org>, Andy Gross <agross@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: crypto: qcom,inline-crypto-engine: Fix legacy/new SoC strictness split
Date: Wed, 8 Jul 2026 08:43:20 +0200	[thread overview]
Message-ID: <20260708-splendid-outrageous-saluki-aa52f5@quoll> (raw)
In-Reply-To: <20260706-b4-shikra_crypto_changse-v3-1-23b4c2054227@oss.qualcomm.com>

On Mon, Jul 06, 2026 at 05:01:29PM +0530, Kuldeep Singh wrote:
> Couple of already merged SoCs(like sc7280, sm8750, kaanapali etc.)
> describe ICE as single clock historically which are recently updated
> with mandatory 2 clocks.
> 
> Keep only the known legacy compatibles flexible, and make strict
> validation default(of power-domains and 2 clocks) for all other Soc
> compatibles.
> 
> This ensures old DTs are valid while ensuring any new SoC (like hawi,
> milos, eliza) must follow latest requirements by default.

To re-iterate: You change the ABI for Hawi, this must be expressed and
explained why. I do not see any change in commit msg (listing "new SoC"
is not what I meant is not relevant here - it even suggests like
everything is here done without impact).

Best regards,
Krzysztof


  reply	other threads:[~2026-07-08  6:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 11:31 [PATCH v3 0/6] Shikra: Add DT support for ICE, RNG and QCE Kuldeep Singh
2026-07-06 11:31 ` [PATCH v3 1/6] dt-bindings: crypto: qcom,inline-crypto-engine: Fix legacy/new SoC strictness split Kuldeep Singh
2026-07-08  6:43   ` Krzysztof Kozlowski [this message]
2026-07-06 11:31 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,inline-crypto-engine: Document Shikra ICE Kuldeep Singh
2026-07-06 11:31 ` [PATCH v3 3/6] dt-bindings: crypto: qcom,prng: Document Shikra TRNG Kuldeep Singh
2026-07-06 11:31 ` [PATCH v3 4/6] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
2026-07-06 11:31 ` [PATCH v3 5/6] dt-bindings: dma: qcom,bam-dma: Increase iommus maxItems to 7 Kuldeep Singh
2026-07-08  6:46   ` Krzysztof Kozlowski
2026-07-06 11:31 ` [PATCH v3 6/6] arm64: dts: qcom: shikra: Add ICE, TRNG and QCE nodes Kuldeep Singh
2026-07-07  4:45 ` [PATCH v3 0/6] Shikra: Add DT support for ICE, RNG and QCE Kuldeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708-splendid-outrageous-saluki-aa52f5@quoll \
    --to=krzk@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox