Re: [PATCH v7 07/10] arm64: dts: qcom: shikra: Enable TSENS and thermal zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] TSENS uplow interrupt must be routed through the MPM for thermal wakeup from sleep.
--

--- Patch [7]: [PATCH v7 07/10] arm64: dts: qcom: shikra: Enable TSENS and thermal zones ---
commit 5c7a177e376df4af941332f06d373b391bca3a3d
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

arm64: dts: qcom: shikra: Enable TSENS and thermal zones

This commit adds the TSENS node and thermal zones for the Shikra SoC.
It configures 14 thermal sensors distributed across the SoC, with hot and
maximum trip points defined at 110°C and 115°C.

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 12e4281f7b358..3abd0a686d0e2 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi

[ ... ]

> @@ -998,6 +999,18 @@ spmi_bus: spmi@1c40000 {
>  			qcom,ee = <0>;
>  		};
>  
> +		tsens0: thermal-sensor@4411000 {
> +			compatible = "qcom,shikra-tsens", "qcom,tsens-v2";
> +			reg = <0x0 0x04411000 0x0 0x1000>,
> +			      <0x0 0x04410000 0x0 0x1000>;
> +			interrupts = <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>,

[Severity: Medium]
Will this interrupt mapping prevent thermal wakeups from deep sleep?

The TSENS0 uplow interrupt is mapped directly to the GIC here. However, since
shikra.dtsi configures the MPM to handle this interrupt on pin 2, does this
need to be routed through the MPM instead?

It seems this should be defined using:
interrupts-extended = <&mpm 2 IRQ_TYPE_LEVEL_HIGH>

If mapped directly to the GIC, if the system heats up while suspended, it
will not wake up at the configured thermal trip points to perform thermal
mitigation or a graceful shutdown. It would eventually rely on the abrupt
hardware reset at 120°C.

> +				     <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH 0>;
> +			interrupt-names = "uplow",
> +					  "critical";
> +			#qcom,sensors = <14>;
> +			#thermal-sensor-cells = <1>;
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-shikra-dt-m1-v7-0-7dc99100c6dd@oss.qualcomm.com?part=7