Re: [PATCH v2 41/64] dmaengine: hsu: kill vchan BH on teardown

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch series structure breaks `git bisect` due to a build failure in the `hsu` driver.
--

--- Patch [41]: [PATCH v2 41/64] dmaengine: hsu: kill vchan BH on teardown ---
commit 53bdccad0464307508ef64c4477dc5f1414579fd
Author: Allen Pais <allen.lkml@gmail.com>

dmaengine: hsu: kill vchan BH on teardown

Use dma_chan_kill_bh() for virt-dma cleanup.

> diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c
> index f62d60d7bc6b7..1a7f9df735a43 100644
> --- a/drivers/dma/hsu/hsu.c
> +++ b/drivers/dma/hsu/hsu.c
> @@ -500,7 +500,7 @@ int hsu_dma_remove(struct hsu_dma_chip *chip)
>  	for (i = 0; i < hsu->nr_channels; i++) {
>  		struct hsu_dma_chan *hsuc = &hsu->chan[i];
>  
> -		tasklet_kill(&hsuc->vchan.task);

[Severity: Medium]
Will this series structure break git bisect?

If the earlier commit "dmaengine: add tasklet-backed channel BH helpers"
removes the task member from struct virt_dma_chan, any kernel checkout
between that commit and this one will fail to compile if the hsu driver is
enabled because it still references hsuc->vchan.task in hsu_dma_remove().

Should the series be reordered so that affected drivers are converted to use the
new API before the task member is removed?

> +		dma_chan_kill_bh(&hsuc->vchan.chan);
>  	}
>  
>  	return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1785183549.git.allen.lkml@gmail.com?part=41