Re: [PATCH v3 3/4] dmaengine: qcom: use named initializers for acpi_device_id

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: qcom: incomplete named initializer transition in hidma_mgmt.c
--

commit 9a66310e86b837e8fbd5ab6a856a4abdb2bbb6cd
Author: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>

    dmaengine: qcom: use named initializers for acpi_device_id

    Use a named initializer for the acpi_device_id fields which makes the code
    more readable and consistent with how lists are initialized in the rest of
    the kernel code base. Unify the list terminator to have a single space
    between the brackets and no trailing comma.

> diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
> index c939635be21d2..1349066b1544d 100644
> --- a/drivers/dma/qcom/hidma.c
> +++ b/drivers/dma/qcom/hidma.c
> @@ -935,10 +935,10 @@ static void hidma_remove(struct platform_device *pdev)
>  
>  #if IS_ENABLED(CONFIG_ACPI)
>  static const struct acpi_device_id hidma_acpi_ids[] = {
> -	{"QCOM8061"},
> -	{"QCOM8062", HIDMA_MSI_CAP},
> -	{"QCOM8063", (HIDMA_MSI_CAP | HIDMA_IDENTITY_CAP)},
> -	{},
> +	{ .id = "QCOM8061" },
> +	{ .id = "QCOM8062", .driver_data = HIDMA_MSI_CAP },
> +	{ .id = "QCOM8063", .driver_data = (HIDMA_MSI_CAP | HIDMA_IDENTITY_CAP) },
> +	{ }
>  };

[Severity: Low]
This isn't a bug, but did this commit miss updating a similar struct in the
same module directory?

drivers/dma/qcom/hidma_mgmt.c:hidma_mgmt_acpi_ids:
static const struct acpi_device_id hidma_mgmt_acpi_ids[] = {
	{"QCOM8060"},
	{},
};

This struct follows the exact same pattern, but was missed by the cleanup,
leading to inconsistent coding styles within the same directory.

>  MODULE_DEVICE_TABLE(acpi, hidma_acpi_ids);
>  #endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-acpi-dma-v3-0-0dac05654967@thegoodpenguin.co.uk?part=3