Re: [PATCHv2] dmaengine: bestcomm: use platform machinery to get irq

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] misc: commit message and code mismatch regarding devm_platform_get_and_ioremap_resource
--

commit e9aa0bc87e702e8cdbc8918ca965897d4edffc03
Author: Rosen Penev <rosenp@gmail.com>

dmaengine: bestcomm: use platform machinery to get irq

This commit updates the bestcomm driver to use platform_get_irq() for
interrupt mapping and replaces of_node references with platform_device. It
also removes the manual device tree node reference counting.

> Replace the open-coded resource lookup, request_mem_region, ioremap and
> the manual iounmap/release_mem_region cleanup in probe/remove with the
> managed devm_platform_get_and_ioremap_resource() helper. This removes the
> now-unused error-unmap/release paths and simplifies the driver.

[Severity: Medium]
Is this paragraph in the commit message accurate for this patch?

Looking at mpc52xx_bcom_probe() in drivers/dma/bestcomm/bestcomm.c around
line 374, the devm_platform_get_and_ioremap_resource() call already exists
prior to this patch (having been introduced in a prior commit,
0a8dda0a15d392).

Since this patch does not actually contain the changes described in this
paragraph, could the commit message be updated to only reflect the changes
introduced here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916224156.276511-1-rosenp@gmail.com?part=1