From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: dmaengine@vger.kernel.org, Binbin Zhou <zhoubinbin@loongson.cn>,
Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>
Subject: Re: [PATCH] dmaengine: loongson: Use %p for pointer formatting
Date: Fri, 18 Sep 2026 19:17:30 +0200 [thread overview]
Message-ID: <20260918171730.HoXci15y@linutronix.de> (raw)
In-Reply-To: <aq1voagTv1oJ8FaA@SMW015318>
On 2026-09-18 12:06:41 [-0500], Frank Li wrote:
> On Fri, Sep 18, 2026 at 12:34:09PM +0200, Sebastian Andrzej Siewior wrote:
> > The %pK format modifier was meant for /proc kind of output, not general
> > printk output. Since commit ad67b74d2469d ("printk: hash addresses
> > printed with %p") pointers are hashed by default and the behaviour can
> > be controller by `hash_pointers' boot argument.
> > The policy on %p is to not introduce new ones. This is the only pointer
> > output in the driver.
> >
> > Remove the pointer formating from debug output.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > index 1c9a542edc859..27f8f7a5738d9 100644
> > --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
> > guard(spinlock_irqsave)(&lchan->vchan.lock);
> >
> > if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> > - dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
>
> You remove whole dev_dbg(), but commit message said Use %p
I redid based on feedback before submitting and forgot to update the
subject. Are you fine with removing it?
> Frank
> > loongson2_cmc_dma_start_transfer(lchan);
> > }
> > }
Sebastian
next prev parent reply other threads:[~2026-09-18 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:34 [PATCH] dmaengine: loongson: Use %p for pointer formatting Sebastian Andrzej Siewior
2026-09-18 17:06 ` Frank Li
2026-09-18 17:17 ` Sebastian Andrzej Siewior [this message]
2026-09-18 19:44 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918171730.HoXci15y@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox