From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16DBC47207B; Sun, 20 Sep 2026 19:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789930845; cv=none; b=SOJVpqd67/7Wci4Z4C5szP+dUb/EUwhkli7sQGsyZFcOusXEonE7UOMTvcX0BAJk8dR8bpO8Kft9FO8MhbHzPaRi1MUohWaC53EQve4M2Xg8y3wSbod3yKigHq7xCX0eg5p2HROr89XRpygWzDLkDXUbVwYNthcmYwyHsWL+5B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789930845; c=relaxed/simple; bh=jg8Ttfc6qe/pB6T1gkzjChXeAfyghZR60TGjRIQSFQo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gaFyWZAj4+NR/hijeHkBJ8jiN6UUkk3H+UndeEXBwSf8Q6HToyOocEZOL1Kxk9SIj9CSna2cx5vwyNp3s7GBuB56Vle8ZRmB/loSWcbxJdXq/Q6S3f6fCA4mIc54nEk4oc88vMbu8xXagzjPIne2NZ1wBW6ALXV3Ehh6il6RSZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IqOWG4sH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IqOWG4sH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 922BB1F000FF; Sun, 20 Sep 2026 19:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789930822; bh=VU3S0qWYRWOoJycbLuEw2ica4z+x14AFZYUiMG09FY0=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=IqOWG4sHIv9LP/v7elKV83bHLbKCk1gV0wD1fAUDK33cAMuZ1SnAbLYsO752o2gGN R60uS9C6nDmLCXVEAVLEbH8Z36IKUlLwy/0ocVZ8m/bRoWOwuDadakGriJJRVI4Nyg RFrj+0glFM7h6GMhDzwJbzTmxrOgDHaBT4Qudqoh664dunc3KsYLSHzEVM9mFm/Pnj F/ttHRHaxTRZSM00CCnPZeJc9mawQN2rvPT7dV9nzyOEsNYppyk/C59EFSygtPCPq5 DMxhTzNOsNBgi9PQIClMvaboitiUb18VP+7UdPsYWwAG+L94dXWLGmis0goBmb/pTy H9BcR2yA9+qgg== From: Linus Walleij Date: Sun, 20 Sep 2026 20:59:58 +0200 Subject: [PATCH v5 23/23] dmaengine: ste_dma40: Validate memcpy configuration Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260920-dma40-fixes-v5-23-5c55cd7f92f9@kernel.org> References: <20260920-dma40-fixes-v5-0-5c55cd7f92f9@kernel.org> In-Reply-To: <20260920-dma40-fixes-v5-0-5c55cd7f92f9@kernel.org> To: Vinod Koul , Frank Li Cc: dmaengine@vger.kernel.org, phone-devel@vger.kernel.org, Linus Walleij , sashiko-bot@kernel.org X-Mailer: b4 0.14.3 d40_config_memcpy() builds a default memcpy configuration without passing it through d40_validate_conf(). A dev_type supplied through the memcpy-channels device tree property can therefore bypass the bounds checks added for client configurations. The generic DMA direction enum assigns zero to DMA_MEM_TO_MEM, unlike DMA40's old private enum. Allow memory-to-memory directions in the validator so checking the generated configuration does not reject all memcpy channels. Validate the generated memcpy configuration before deriving logical channel registers or allocating the channel. Fixes: 2c2b62d5d911 ("dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones") Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/dmaengine/20260819225008.5F9651F000E9@smtp.kernel.org/ Assisted-by: LLM Signed-off-by: Linus Walleij --- drivers/dma/ste_dma40.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index a3159a657040..57d556e46402 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -1885,7 +1885,8 @@ static int d40_validate_conf(struct d40_chan *d40c, d40c->base->gen_dmac.num_event_groups) invalid_dev_type = true; - if (!conf->dir) { + if (conf->dir != DMA_MEM_TO_MEM && + !is_slave_direction(conf->dir)) { chan_err(d40c, "Invalid direction.\n"); res = -EINVAL; } @@ -2159,12 +2160,17 @@ static int d40_allocate_channel(struct d40_chan *d40c, bool *first_phy_user) static int d40_config_memcpy(struct d40_chan *d40c) { dma_cap_mask_t cap = d40c->chan.device->cap_mask; + int ret; if (dma_has_cap(DMA_MEMCPY, cap) && !dma_has_cap(DMA_SLAVE, cap)) { d40c->dma_cfg = dma40_memcpy_conf_log; d40c->dma_cfg.dev_type = d40c->base->plat_data->memcpy_channels[d40c->chan.chan_id]; + ret = d40_validate_conf(d40c, &d40c->dma_cfg); + if (ret) + return ret; + d40_log_cfg(&d40c->dma_cfg, &d40c->log_def.lcsp1, &d40c->log_def.lcsp3); @@ -2172,6 +2178,10 @@ static int d40_config_memcpy(struct d40_chan *d40c) dma_has_cap(DMA_SLAVE, cap)) { d40c->dma_cfg = dma40_memcpy_conf_phy; + ret = d40_validate_conf(d40c, &d40c->dma_cfg); + if (ret) + return ret; + /* Generate interrupt at end of transfer or relink. */ d40c->dst_def_cfg |= BIT(D40_SREG_CFG_TIM_POS); -- 2.55.0