From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: dmaengine@vger.kernel.org, Binbin Zhou <zhoubinbin@loongson.cn>,
Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>
Subject: [PATCH v3] dmaengine: loongson: Remove the dev_dbg() output
Date: Mon, 21 Sep 2026 17:13:12 +0200 [thread overview]
Message-ID: <20260921151312.I8Q8NLnx@linutronix.de> (raw)
The %pK format modifier was meant for /proc kind of output, not general
printk output. Since commit ad67b74d2469d ("printk: hash addresses
printed with %p") pointers are hashed by default and the behaviour can
be controller by `hash_pointers' boot argument.
The policy on %p is to not introduce new ones.
The output in loongson2_cmc_dma_issue_pending() is the only dev_dbg()
output in the driver and is only output once the transfer is started.
There is no output issued by the driver if the transfer is completed, if
a follow-up transfer is started or if any of the other callbacks (such
as loongson2_cmc_dma_tx_status()) are invoked. This output does not look
essential.
Instead removing just the %pK output, remove the complete dev_dbg()
output from the driver.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
On 2026-09-18 16:44:59 [-0500], Frank Li wrote:
>
> please careful,
>
> remove whole dev_dbg() when vchan_issue_pending() failure.
>
> commit messesge should show why it is okay to remove dev_dbg() here.
Is the arguing now reasonable?
> Frank
v2…v3: https://lore.kernel.org/all/20260918201714.eFNI3VMq@linutronix.de/
- Reword part of the commit message.
v1…v2: https://lore.kernel.org/all/20260918103409.UV4g2ON7@linutronix.de/
- Update subject line (it is removed, not replaced).
drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
index 1c9a542edc859..27f8f7a5738d9 100644
--- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
+++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
@@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
guard(spinlock_irqsave)(&lchan->vchan.lock);
if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
- dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
loongson2_cmc_dma_start_transfer(lchan);
}
}
--
2.55.0
next reply other threads:[~2026-09-21 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:13 Sebastian Andrzej Siewior [this message]
2026-09-21 15:16 ` [PATCH v3] dmaengine: loongson: Remove the dev_dbg() output sashiko-bot
2026-09-21 16:04 ` Frank Li
2026-09-21 16:03 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921151312.I8Q8NLnx@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox