Re: [PATCHv8] dmaengine: fsl_raid: check fsl_re_chan_probe() return value

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dmaengine: fsl_raid: unconditional total_chans increment contradicts commit
--

commit 208ae247c55a1b6bf4d94121e4104ab723b71bae
Author: Rosen Penev <rosenp@gmail.com>

dmaengine: fsl_raid: check fsl_re_chan_probe() return value

The commit adds a check for fsl_re_chan_probe() failure in fsl_re_probe()
to prevent leaving uninitialized array elements in re_jrs[]. It also adds
a cleanup path to correctly tear down channels if an error occurs.

> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 2d86f61105e52..352e8cc9e8c71 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
[ ... ]
> @@ -824,33 +839,46 @@ static int fsl_re_probe(struct platform_device *ofdev)
[ ... ]
>  		/* Find out the Job Rings present under each JQ */
>  		for_each_child_of_node(np, child) {
> -			rc = of_device_is_compatible(child,
> -					     "fsl,raideng-v1.0-job-ring");
> -			if (rc) {
> -				fsl_re_chan_probe(ofdev, child, ridx++, off);
> -				re_priv->total_chans++;
> +			if (!of_device_is_compatible(child, "fsl,raideng-v1.0-job-ring"))
> +				continue;
> +
> +			if (ridx >= FSL_RE_MAX_CHANS) {
> +				dev_warn(dev, "too many job rings, max %d\n", FSL_RE_MAX_CHANS);
> +				of_node_put(child);
> +				break;
>  			}
> +
> +			rc = fsl_re_chan_probe(ofdev, child, ridx, off);
> +			if (rc)
> +				dev_err(dev, "job ring %d probe failed: %d\n", ridx, rc);
> +			re_priv->total_chans++;
> +			ridx++;
>  		}

[Severity: Medium]
The commit message states "only count successfully probed channels", but does
this code still unconditionally increment the counters?

If fsl_re_chan_probe() fails and returns a non-zero rc, it logs an error but 
then falls through to increment re_priv->total_chans and ridx since there is 
no continue statement. This advances the counters even for failed probes,
wasting slots in the fixed-size re_jrs array. Should this include a continue
when rc is non-zero?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921222544.52655-1-rosenp@gmail.com?part=1