From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: dmaengine@vger.kernel.org, vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 1/2] dmaengine: ti: edma: fix pm_runtime usage counter leak on error
Date: Wed, 23 Sep 2026 04:16:38 +0000 [thread overview]
Message-ID: <20260923041639.1EF301F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923040831.10936-1-phucduc.bui@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dmaengine: commit message wrongly references netcp_probe()
--
commit 46b6daf75a4d492c8e72053cb40b58c95d74f2fd
Author: bui duc phuc <phucduc.bui@gmail.com>
dmaengine: ti: edma: fix pm_runtime usage counter leak on error
This commit replaces pm_runtime_get_sync() with pm_runtime_resume_and_get()
to prevent leaking a runtime PM usage counter reference on error paths.
> pm_runtime_get_sync() leaves the runtime PM usage counter incremented even
> when it fails, but the error path in netcp_probe() does not call
> pm_runtime_put_noidle() to balance it, leaking a reference each time
> resume fails.
[Severity: Medium]
The commit message references netcp_probe(), but the patch actually modifies
edma_probe() in drivers/dma/ti/edma.c. Could the commit message be updated to
reflect the correct function name being patched?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923040831.10936-1-phucduc.bui@gmail.com?part=1
next prev parent reply other threads:[~2026-09-23 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 4:08 [PATCH 1/2] dmaengine: ti: edma: fix pm_runtime usage counter leak on error phucduc.bui
2026-09-23 4:08 ` [PATCH 2/2] dmaengine: ti: edma: Fix missing pm_runtime cleanup on probe failure phucduc.bui
2026-09-23 4:16 ` sashiko-bot [this message]
2026-09-23 4:29 ` [PATCH 1/2] dmaengine: ti: edma: fix pm_runtime usage counter leak on error Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923041639.1EF301F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox