DMA Engine development
 help / color / mirror / Atom feed
From: Joshua Crofts <crofts@kernel.org>
To: Ludovic Desroches <ludovic.desroches@microchip.com>,
	Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: [PATCH 3/3] dmaengine: ti: remove redundant pm_runtime_dont_use_autosuspend() calls
Date: Fri, 30 Oct 2026 14:59:01 +0000	[thread overview]
Message-ID: <20261030145901.1393-4-crofts@kernel.org> (raw)
In-Reply-To: <20261030145901.1393-1-crofts@kernel.org>

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls. Additionally, remove an unneeded
label as a consequence.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/dma/ti/cppi41.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
index 88756dccd62c..e1132e330fad 100644
--- a/drivers/dma/ti/cppi41.c
+++ b/drivers/dma/ti/cppi41.c
@@ -1108,7 +1108,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
 
 	ret = init_cppi41(dev, cdd);
 	if (ret)
-		goto err_init_cppi;
+		goto err_get_n_chans;
 
 	ret = cppi41_add_chans(dev, cdd);
 	if (ret)
@@ -1142,8 +1142,6 @@ static int cppi41_dma_probe(struct platform_device *pdev)
 	dma_async_device_unregister(&cdd->ddev);
 err_chans:
 	deinit_cppi41(dev, cdd);
-err_init_cppi:
-	pm_runtime_dont_use_autosuspend(dev);
 err_get_n_chans:
 err_get_sync:
 	pm_runtime_put_sync(dev);
@@ -1165,7 +1163,6 @@ static void cppi41_dma_remove(struct platform_device *pdev)
 
 	devm_free_irq(&pdev->dev, cdd->irq, cdd);
 	deinit_cppi41(&pdev->dev, cdd);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_sync(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 }
-- 
2.47.3


      parent reply	other threads:[~2026-10-30 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 14:58 [PATCH 0/3] dmaengine: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-10-30 14:58 ` [PATCH 1/3] dmaengine: at_xdmac: " Joshua Crofts
2026-10-30 14:59 ` [PATCH 2/3] dmaengine: qcom: " Joshua Crofts
2026-10-30 14:59 ` Joshua Crofts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261030145901.1393-4-crofts@kernel.org \
    --to=crofts@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox