From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get_irq() From: Pierre Yves MORDRET Message-Id: <20f014c3-0511-2b43-bcd2-1ca8cc700d54@st.com> Date: Wed, 24 Apr 2019 11:27:20 +0200 To: Fabien Dessenne , Vinod Koul , Dan Williams , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: SGVsbG8KClJldmlld2VkLWJ5OiBQaWVycmUtWXZlcyBNT1JEUkVUIDxwaWVycmUteXZlcy5tb3Jk cmV0QHN0LmNvbT4KClRoYW5rcwoKT24gNC8yNC8xOSAxMToyMSBBTSwgRmFiaWVuIERlc3Nlbm5l IHdyb3RlOgo+IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX0lSUSkgaXMg bm90IHJlY29tbWVuZGVkIGZvcgo+IHJlcXVlc3RpbmcgSVJRJ3MgcmVzb3VyY2VzLCBhcyB0aGV5 IGNhbiBiZSBub3QgcmVhZHkgeWV0LiBVc2luZwo+IHBsYXRmb3JtX2dldF9pcnEoKSBpbnN0ZWFk IGlzIHByZWZlcnJlZCBmb3IgZ2V0dGluZyBJUlEgZXZlbiBpZiBpdCB3YXMKPiBub3QgcmV0cmll dmVkIGVhcmxpZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRmFiaWVuIERlc3Nlbm5lIDxmYWJpZW4u ZGVzc2VubmVAc3QuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2RtYS9zdG0zMi1kbWEuYyB8IDExICsr KysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL3N0bTMyLWRtYS5jIGIvZHJpdmVycy9k bWEvc3RtMzItZG1hLmMKPiBpbmRleCBiYTIzOWI1Li4zMzA2ODE4IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZG1hL3N0bTMyLWRtYS5jCj4gKysrIGIvZHJpdmVycy9kbWEvc3RtMzItZG1hLmMKPiBA QCAtMTMwMiwxMyArMTMwMiwxNCBAQCBzdGF0aWMgaW50IHN0bTMyX2RtYV9wcm9iZShzdHJ1Y3Qg cGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAKPiAgCWZvciAoaSA9IDA7IGkgPCBTVE0zMl9ETUFf TUFYX0NIQU5ORUxTOyBpKyspIHsKPiAgCQljaGFuID0gJmRtYWRldi0+Y2hhbltpXTsKPiAtCQly ZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9JUlEsIGkpOwo+IC0J CWlmICghcmVzKSB7Cj4gLQkJCXJldCA9IC1FSU5WQUw7Cj4gLQkJCWRldl9lcnIoJnBkZXYtPmRl diwgIk5vIGlycSByZXNvdXJjZSBmb3IgY2hhbiAlZFxuIiwgaSk7Cj4gKwkJY2hhbi0+aXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCBpKTsKPiArCQlpZiAoY2hhbi0+aXJxIDwgMCkgIHsKPiAr CQkJcmV0ID0gY2hhbi0+aXJxOwo+ICsJCQlpZiAocmV0ICE9IC1FUFJPQkVfREVGRVIpCj4gKwkJ CQlkZXZfZXJyKCZwZGV2LT5kZXYsCj4gKwkJCQkJIk5vIGlycSByZXNvdXJjZSBmb3IgY2hhbiAl ZFxuIiwgaSk7Cj4gIAkJCWdvdG8gZXJyX3VucmVnaXN0ZXI7Cj4gIAkJfQo+IC0JCWNoYW4tPmly cSA9IHJlcy0+c3RhcnQ7Cj4gIAkJcmV0ID0gZGV2bV9yZXF1ZXN0X2lycSgmcGRldi0+ZGV2LCBj aGFuLT5pcnEsCj4gIAkJCQkgICAgICAgc3RtMzJfZG1hX2NoYW5faXJxLCAwLAo+ICAJCQkJICAg ICAgIGRldl9uYW1lKGNoYW4yZGV2KGNoYW4pKSwgY2hhbik7Cj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38F4C10F11 for ; Wed, 24 Apr 2019 09:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E6D920878 for ; Wed, 24 Apr 2019 09:27:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="HDTvYV3W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbfDXJ1k (ORCPT ); Wed, 24 Apr 2019 05:27:40 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:58822 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfDXJ1j (ORCPT ); Wed, 24 Apr 2019 05:27:39 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3O9MOwQ020109; Wed, 24 Apr 2019 11:27:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=Np/3S0I0cy9sOf0bpvtPMHGI+KAGlta3TBJOf7x9EAc=; b=HDTvYV3WstZzVIUD4AnnuGVudDgMOIuigIoHWCpZ6BVQD4xPk+22iPVlJOJ0ocCdAvEb RunryB13s0OsJ6ckAfZhCpZYRm2Rc7vXf3y7YDpPRDUpbimOvL9//rOg7K7VyjtaiZdj G3dNdXExGirggJN4G3FQkoERw0/DlN3S2NfvntBGKHBlEQbpXEajMgwepU6d+8dM5IPM pL/crnQwk2Q2pOyhj9YlzN0XUEYNPFQ+OXNH1c/1yICeXbuU3OetNdWZ5Sx4bT2KP6ZG XE9tD8nrdZObRjE3ItpV+8a5rj+cpdaaQ6PMSP4tDe5CBLLMxDVYr2/C3hmF+Vwv41Wu Ww== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ryrvxckck-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Apr 2019 11:27:22 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6E7CD34; Wed, 24 Apr 2019 09:27:21 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4CB691578; Wed, 24 Apr 2019 09:27:21 +0000 (GMT) Received: from [10.48.1.93] (10.75.127.47) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 24 Apr 2019 11:27:20 +0200 Subject: Re: [PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get_irq() To: Fabien Dessenne , Vinod Koul , Dan Williams , Maxime Coquelin , Alexandre Torgue , , , , References: <1556097685-7236-1-git-send-email-fabien.dessenne@st.com> From: Pierre Yves MORDRET Message-ID: <20f014c3-0511-2b43-bcd2-1ca8cc700d54@st.com> Date: Wed, 24 Apr 2019 11:27:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1556097685-7236-1-git-send-email-fabien.dessenne@st.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-24_07:,, signatures=0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190424092720.j-u9DN_xYuLGtc3Zh3fsJIRdf_2vDICyihwzRLUfruA@z> Hello Reviewed-by: Pierre-Yves MORDRET Thanks On 4/24/19 11:21 AM, Fabien Dessenne wrote: > platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for > requesting IRQ's resources, as they can be not ready yet. Using > platform_get_irq() instead is preferred for getting IRQ even if it was > not retrieved earlier. > > Signed-off-by: Fabien Dessenne > --- > drivers/dma/stm32-dma.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c > index ba239b5..3306818 100644 > --- a/drivers/dma/stm32-dma.c > +++ b/drivers/dma/stm32-dma.c > @@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev) > > for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) { > chan = &dmadev->chan[i]; > - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); > - if (!res) { > - ret = -EINVAL; > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > + chan->irq = platform_get_irq(pdev, i); > + if (chan->irq < 0) { > + ret = chan->irq; > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "No irq resource for chan %d\n", i); > goto err_unregister; > } > - chan->irq = res->start; > ret = devm_request_irq(&pdev->dev, chan->irq, > stm32_dma_chan_irq, 0, > dev_name(chan2dev(chan)), chan); >